Power op PCC drop issue #13874
Merged
Power op PCC drop issue #13874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umadevimcw
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3 and
dongjin-na
as code owners
umadevimcw
force-pushed
the
umadevimcw/power_bug
branch
from
ed19ce0
to
588b982
Compare
rfurko-tt
reviewed
Oct 16, 2024
| @@ -15,7 +15,7 @@ | |||
| def run_pow_tests(input_shape, dtype, dlayout, in_mem_config, output_mem_config, data_seed, device): | |||
| torch.manual_seed(data_seed) | |||
|
|
|||
| x = torch.Tensor(size=input_shape[0]).uniform_(-100, 100).to(torch.bfloat16) | |||
| x = torch.Tensor(size=input_shape[0]).uniform_(-100, 100) | |||
There was a problem hiding this comment.
- should we move this test out of
non_working_unit_testsfolder? - previously we were testing bfloat16 pow operation, now it's pow operation for float32, right?
If true, should we just update range for x (...uniform_(-5, 5).to(torch.bfloat16)for example) to be a better match for previous test intention?
There was a problem hiding this comment.
Even if we minimize the range again the values will be a larger number if it is bf16 in torch, then if we don't do conversion the result will be nan. In TT version of pwer of we are explicitly checking for negative value, if the value is negative it will return nan
There was a problem hiding this comment.
In TT we explicitly added a condition to return NaN if the values are negative. In torch for BF16 Nan is represented in large values instead of NaN which will be causing PCC drop hence removed the conversion part in torch ref code in this file
umadevimcw
force-pushed
the
umadevimcw/power_bug
branch
from
588b982
to
c7ea982
Compare
umadevimcw
requested review from
patrickroberts and
yan-zaretskiy
as code owners
eyonland
approved these changes
Oct 22, 2024
umadevimcw
force-pushed
the
umadevimcw/power_bug
branch
from
c7ea982
to
86f84f6
Compare
ayerofieiev-tt
approved these changes
Oct 24, 2024
umadevimcw
force-pushed
the
umadevimcw/power_bug
branch
from
86f84f6
to
bea5725
Compare
umadevimcw
force-pushed
the
umadevimcw/power_bug
branch
from
bea5725
to
576b9ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#8593
Problem description
PCC drop for power op
What's changed
Explained the reason why change is required in this -
#8593 (comment)
Checklist