Skip to content

Commit

Permalink
#12496: Do not use output variables if we can simplify the workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
dimitri-tenstorrent committed Nov 25, 2024
1 parent 4f6aff9 commit cbd13ee
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/publish-release-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ on:
default: 35
jobs:
create-docker-image:
outputs:
image_tag_grayskull: ${{ steps.generate-tag-name.outputs.tag_name_grayskull }}
image_tag_wormhole_b0: ${{ steps.generate-tag-name.outputs.tag_name_wormhole_b0 }}
strategy:
matrix:
os: [ubuntu-20.04]
Expand Down Expand Up @@ -49,7 +46,6 @@ jobs:
echo "REPO_IMAGE_NAME=$REPO_IMAGE_NAME" >> $GITHUB_ENV
TAG_NAME=$REPO_IMAGE_NAME:${{ inputs.version }}
echo "TAG_NAME=$TAG_NAME" >> $GITHUB_ENV
echo "tag_name_${{ matrix.arch }}=$TAG_NAME" >> $GITHUB_OUTPUT
- name: Build and push
uses: docker/build-push-action@v6
with:
Expand Down Expand Up @@ -90,7 +86,6 @@ jobs:
docker_password: ${{ secrets.GITHUB_TOKEN }}
run_args: |
pytest tests/end_to_end_tests
docker_image: ${{ needs.create-docker-image.outputs[format('image_tag_{0}', matrix.test_group.arch)] }}
tag-docker-image-as-latest:
needs: [smoke-test-docker-image, create-docker-image]
strategy:
Expand All @@ -104,8 +99,8 @@ jobs:
- name: Tag latest if this is a major version release
if: ${{ inputs.is_major_version }}
run: |
TAG_NAME=${{ needs.create-docker-image.outputs[format('image_tag_{0}', matrix.arch)] }}
REPO_IMAGE_NAME=$(echo $TAG_NAME | cut -d':' -f1)
REPO_IMAGE_NAME=ghcr.io/${{ github.repository }}/tt-metalium-${{ matrix.os }}-amd64-dev/${{ matrix.arch }}
TAG_NAME=$REPO_IMAGE_NAME:${{ inputs.version }}
docker pull $TAG_NAME
docker tag $TAG_NAME $REPO_IMAGE_NAME:latest
docker push $REPO_IMAGE_NAME:latest

0 comments on commit cbd13ee

Please sign in to comment.