Skip to content

Commit

Permalink
#0: Disable Unity builds to detect bitrot (#15017)
Browse files Browse the repository at this point in the history
### Ticket
None

### Problem description
A header file missed an include and went undetected in CI because Unity
builds accidentally provided the needed include in the combined TU.

### What's changed
Disabled Unity builds for CI
Added the missing include

### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] New/Existing tests provide coverage for changes

---------

Co-authored-by: Bryan Wilder Field Lozano <blozano@tenstorrent.com>
  • Loading branch information
afuller-TT and blozano-tt authored Nov 13, 2024
1 parent 268f429 commit 3c70880
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/build-artifact.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ jobs:
# NOTE: may be inaccurate if we have >1 build runner on the same machine, using the same local cache
ccache -z
build_command="./build_metal.sh --build-type ${{ inputs.build-type }} --build-all --enable-ccache"
# Disable Unity builds to detect any bitrot from not building each TU independently
build_command="./build_metal.sh --build-type ${{ inputs.build-type }} --build-all --enable-ccache --disable-unity-builds"
echo "${{ inputs.tracy }}"
if [ "${{ inputs.tracy }}" = "true" ]; then
build_command="$build_command --enable-profiler"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include "tt_metal/common/work_split.hpp"
#include "tt_metal/detail/util.hpp"
#include "tt_metal/host_api.hpp"
#include "ttnn/cpp/ttnn/operation.hpp"

namespace ttnn::operations::data_movement::detail {

Expand Down

0 comments on commit 3c70880

Please sign in to comment.