-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert aten.bitwise_not
to ttnn.bitwise_not
#236
base: main
Are you sure you want to change the base?
Conversation
) | ||
def test_bitwise_not(device, input_shape): | ||
m = BitwiseNotModule() | ||
input = torch.randint(-256, 256, input_shape, dtype=torch.int32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a problem. I make this tensor in torch.int32
, but the test complains that it gets a BFLOAT16 tensor.
E RuntimeError: TT_FATAL @ /home/jdh8/tt-metal/ttnn/cpp/ttnn/operations/eltwise/unary/device/unary_device_operation.cpp:42: input_datatype == DataType::INT32
E info:
E Unsupported input data type '0' for UnaryOpType '63' (Bitwise operation).
E backtrace:
E --- /home/jdh8/tt-metal/ttnn/ttnn/_ttnn.so(+0x4933a9) [0x7f0db03ee3a9]
E --- ttnn::operations::unary::UnaryDeviceOperation::validate_on_program_cache_miss(ttnn::operations::unary::operation_attributes_t const&, ttnn::operations::unary::tensor_args_t const&)
Previous error message also confirms this.
tenstorrent/tt-metal#12902 does not fix this error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinwuTT ptal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error still persists after merging tenstorrent/tt-metal#13579.
a99e6cd
to
b2f9acb
Compare
`ttnn.bitwise_not` takes an extraneous `value: int`. I'm fixing this in the kernel.
b2f9acb
to
ad35b3a
Compare
Ticket
Depends on tenstorrent/tt-metal#12902
Problem description
ttnn.bitwise_not
takes an extraneousvalue: int
. I'm fixing this in the kernel.What's changed
aten.bitwise_not
tottnn.bitwise_not
ttnn.bitwise_not
in the kernel (either of the following)value: int
parameter fromttnn.bitwise_not
tt-metal#12902