Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing deprecated keyword lr by new learning_rate #482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddanielvaz
Copy link

There are deprecated warning when running examples of udacity course, because the keyword was deprecated, running examples with default learning rate (0.01) do not give expected results, confusing the course attendants.

Copy link

google-cla bot commented Jan 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jan 28, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull labels Feb 1, 2024
@MarkDaoust
Copy link
Member

Thanks!

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 1, 2024
@ddanielvaz ddanielvaz closed this Feb 1, 2024
@ddanielvaz ddanielvaz reopened this Feb 1, 2024
@ddanielvaz
Copy link
Author

@JosBecker please, could you provide review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S CL Change Size: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants