-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve test suite testutil/keeper by adding utility methods for state initialization #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muku314115
requested review from
ilgooz,
jeronimoalbi and
Pantani
as code owners
November 6, 2023 08:33
muku314115
changed the title
Improve test suite testutil/keeper by adding utility methods for state initialization
chore: improve test suite testutil/keeper by adding utility methods for state initialization
Nov 6, 2023
jeronimoalbi
reviewed
Nov 6, 2023
jeronimoalbi
previously approved these changes
Nov 6, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
- Coverage 71.38% 71.37% -0.02%
==========================================
Files 218 218
Lines 9471 9471
==========================================
- Hits 6761 6760 -1
- Misses 2538 2539 +1
Partials 172 172 |
Pantani
previously approved these changes
Nov 27, 2023
Pantani
reviewed
Nov 27, 2023
Pantani
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #808
What does this PR do?
Code cleanup, adding utilities to reduce initialization code
How to test?
Checklist
These are the criteria that every PR should meet, please check them off as you
review them: