Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ENTRYPOINT instead of CMD to run promqltodd #61

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Use ENTRYPOINT instead of CMD to run promqltodd #61

merged 1 commit into from
Aug 21, 2023

Conversation

taonic
Copy link
Collaborator

@taonic taonic commented Aug 19, 2023 •
edited
Loading

What was changed

Use ENTRYPOINT to replace CMD in promql-to-dd-go Dockerfile.

Why?

Requested at: #60

This is to add convenience to run the image as a binary by supplying flags directly without specifying the executable.

Checklist

  1. Closes [Bug] promql-to-dd docker image does not define entrypoint #60
  2. How was this tested: Manually..

@taonic taonic requested a review from TimSimmons August 19, 2023 07:42
@taonic taonic merged commit 966c8c4 into main Aug 21, 2023
4 checks passed
@taonic taonic deleted the taonic/use_entrypoint_in_promqltodd_image branch August 21, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimSimmons TimSimmons TimSimmons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] promql-to-dd docker image does not define entrypoint
2 participants
@taonic @TimSimmons