Add the homogenised Laplace operator #86

removr · 2024-02-13T09:58:59Z

Implements the homogenised Laplace operator with the help of solid spherical harmonics. The coefficients of the expansion are calculated with Eigen.

conversion pointer to vector

system matrix for gradient lines

the geometry is correct though

homogenisation

mx-nlte

I like your Doxygen comments

mx-nlte · 2024-02-13T12:25:45Z

Bembel/src/util/Sphericals.hpp

+#include <Eigen/Dense>
+
+#if !defined pi
+#define pi 3.1415926535897932385


We have a macro BEMBEL_PI define in "Bembel/src/util/Macros.hpp". Please exchange

mx-nlte · 2024-02-13T12:28:49Z

Bembel/src/util/Sphericals.hpp

+  double z1[2], z2[2], z3[2], z1_start[2];
+  double r, fac, rootTimesZ, root_2, root_3;
+
+  assert(abs(x.norm() - 1) < 1e-14);


Please use Constants::generic_tolerance instead of a hard coded tolerance.

mx-nlte · 2024-02-13T12:30:49Z

examples/CMakeLists.txt

@@ -17,6 +17,8 @@ set(CIFILES
    LaplaceSingleLayerH2
    HelmholtzSingleLayerFull
    HelmholtzSingleLayerH2
+	HomogenisedLaplaceSingleLayerFull


Please align with the other file names.

mx-nlte · 2024-02-13T12:32:58Z

Bembel/src/util/Sphericals.hpp

+  Eigen::Vector3d dr;
+  double fac, rootTimesZ, root_2, root_3;
+
+  assert(abs(x.norm() - 1) < 1e-14);


Please use Constants::generic_tolerance instead of a hard coded tolerance.

mx-nlte · 2024-02-13T12:35:29Z

Bembel/src/HomogenisedLaplace/SingleLayerPotential.hpp

+  // implementation of the kernel evaluation, which may be based on the
+  // information available from the superSpace
+
+ private:


(optional) private members are at the bottom of the class definition in Bembel.

mx-nlte · 2024-02-13T12:41:37Z

tests/test_HomogenisedCoefficients.cpp

+#include <iostream>
+#include <functional>
+
+#include "./Test.hpp"


replace '.' with 'tests'

mx-nlte · 2024-02-13T12:43:16Z

Bembel/HomogenisedLaplace

@@ -0,0 +1,25 @@
+// This file is part of Bembel, the higher order C++ boundary element library.
+// It was written as part of a cooperation of J. Doelz, H. Harbrecht, S. Kurz,


Replace with new header including the copy right.

mx-nlte · 2024-02-13T12:44:57Z

Bembel/src/HomogenisedLaplace/Coefficients.hpp

+#endif
+
+#ifndef PI
+#define PI M_PI


Please use M_PI directly.

mx-nlte · 2024-02-13T12:45:55Z

Bembel/src/HomogenisedLaplace/SingleLayerOperator.hpp

+    HomogenisedLaplaceSingleLayerOperator> {
+  // implementation of the kernel evaluation, which may be based on the
+  // information available from the superSpace
+ private:


Here are the same points as in the SingleLayerPotential.hpp

mx-nlte · 2024-02-13T12:46:22Z

examples/HomogenisedLaplaceSingleLayerH2.cpp

+
+#include <iostream>
+
+#include "./Data.hpp"


Same as in the other example

mx-nlte · 2024-02-13T12:48:24Z

We should add one line in the examples/CMakeFile.txt to copy the geometry.

remo added 30 commits January 3, 2023 15:47

added the spherical harmonics file

f4814f4

creating a feature branch for the coefficient calculation

a27469a

added the initialisation of the right-hand side

82826e7

need the full spherical harmonics for further continuation

b7df6f9

added the full sphericals, but some bugs might have come in form the

111f806

conversion pointer to vector

added the coefficient calculation, needs to be tested

f372418

added a test file for the coefficients

828be33

the test file compiles and runs now, but there is still a bug somewhere

c75b864

fixed a bug, the displacement works now

0463c34

fixed another bug, there is still a nasty factor 2 for m = n in the

dfc7607

system matrix for gradient lines

the coefficients are now up to the first one calculated correctly

dbe769c

added a routine for the first coefficient

f9b3805

fixed a bug, changed a - to a plus

fc17305

added the single layer operator

0794a22

added the potential and the operator and an example file, not sure if

99765b3

the geometry is correct though

added the small cube via octave

30b3b0e

added a Multipole example and removed the auto variables

bf09473

merge Single Layer Operator files of homogenisedOperators into

d702ea8

homogenisation

added the coding conventions to Coefficients.hpp

2d81e1c

added the cpplint conventions to Sphericals.cpp

929c6ca

added the cpplint conventions to the single layer operator

eeb4270

added the cpplint conventions to SingleLayerPotential.hpp

052d125

added the cpplint conventions to the examples and test

9906502

Documented the Sphericals using Doxygen and MathJax

7ec78bd

worked on the documentation

bdbc372

documented the Potential and the Operator

933fa93

included Constants::isAlmostZero in the test

f72ca7b

Merge remote-tracking branch 'upstream/master' into homogenisationUpdate

9d2d400

added the correct header to the examples and the test file

598ab5c

included the headers into the Operator and Potential

60dd6a4

remo added 5 commits June 20, 2023 15:43

removed the Doxygen file

4c76452

Adds the Tests to the CMake Files

f658e99

Adds myself to README.md

f015261

Merge remote-tracking branch 'upstream/master' into homogenisationUpdate

b40f16e

Reads a geometry file in the working directory

28ca108

mx-nlte self-assigned this Feb 13, 2024

mx-nlte self-requested a review February 13, 2024 12:16

mx-nlte reviewed Feb 13, 2024

View reviewed changes

remo added 5 commits February 13, 2024 19:38

Adds the small cube to the CMakeLists file

017e718

includes some minor changes in the overall code style

4727ca1

adds the convergence rate check to the homogenised H2 example

a8ff152

includes the Convergence order check in the Homogenised full example

c3ceac2

chenges the grid for the full example

ad6af5f

mx-nlte approved these changes Feb 14, 2024

View reviewed changes

mx-nlte merged commit cc1aa71 into temf:master Feb 14, 2024
4 checks passed

removr deleted the homogenisationUpdate branch February 14, 2024 14:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the homogenised Laplace operator #86

Add the homogenised Laplace operator #86

removr commented Feb 13, 2024

mx-nlte left a comment

mx-nlte Feb 13, 2024

removr Feb 14, 2024

mx-nlte Feb 13, 2024

removr Feb 14, 2024

mx-nlte Feb 13, 2024

removr Feb 14, 2024

mx-nlte Feb 13, 2024

removr Feb 14, 2024

mx-nlte Feb 13, 2024

removr Feb 14, 2024

mx-nlte Feb 13, 2024

removr Feb 14, 2024

mx-nlte Feb 13, 2024

removr Feb 14, 2024

mx-nlte Feb 13, 2024

removr Feb 14, 2024

mx-nlte Feb 13, 2024

mx-nlte Feb 13, 2024

removr Feb 14, 2024

mx-nlte commented Feb 13, 2024

		@@ -0,0 +1,25 @@
		// This file is part of Bembel, the higher order C++ boundary element library.
		// It was written as part of a cooperation of J. Doelz, H. Harbrecht, S. Kurz,


		#include <iostream>

		#include "./Data.hpp"

Add the homogenised Laplace operator #86

Add the homogenised Laplace operator #86

Conversation

removr commented Feb 13, 2024

mx-nlte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mx-nlte commented Feb 13, 2024