Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch PR for dev branch before going production #883

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Patch PR for dev branch before going production #883

merged 3 commits into from
Nov 25, 2024

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Nov 23, 2024

Problems found and fixed:

  • There were a lot of forgotten console logs with a comment to be removed (but I never did) so I'm making this patch PR to remove those logs before going to the master branch
  • There was a text translated only for English and missing for all other languages. That line was added.
  • I also removed an unused parameter from a function (eslint was complaining about it)

@Viterbo Viterbo self-assigned this Nov 23, 2024
Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 129c163
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/67411fa7f67d7c00087e0eed
😎 Deploy Preview https://deploy-preview-883--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 129c163
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/67411fa770fa38000823f003
😎 Deploy Preview https://deploy-preview-883--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit 129c163
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/67411fa74cd71e0008d0f04d
😎 Deploy Preview https://deploy-preview-883--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo changed the title Removing all console.logs from TupleStruct.vue PAtch PR for dev branch before going production Nov 23, 2024
@Viterbo Viterbo changed the title PAtch PR for dev branch before going production Patch PR for dev branch before going production Nov 23, 2024
@Viterbo Viterbo mentioned this pull request Nov 23, 2024
@poplexity poplexity self-requested a review November 24, 2024 18:18
Copy link
Member

@poplexity poplexity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Viterbo Viterbo merged commit dbc2471 into dev Nov 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants