-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global getWeb3Provider fixed #775
Global getWeb3Provider fixed #775
Conversation
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @ezra-sg, that was EPIC!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! seems to work well for me. i found an issue but it is also present on master, so not due to this PR. I created this: #779
Fixes #772
Description
This PR fixes the bug described in the issue #772. The problem was that the global getWeb3Provider was returning the current authenticator's provider as the first option not taking into account that you may be using Metamask but at this moment it is pointing to another blockchain. So it does not work.
Now the only possible answer is a JsonRpcProvider which works pretty well for reading the blockchain contracts.
Test scenarios
Login into your Metamask and change the network to Ethereum
Then visit this link. You will get a "not found" sign:
https://wallet.telos.net/evm/collectible-details?contract=0x63F8948c2Ee0670758A4E60EED80aAa6Cf093356&id=1141&tab=attributes
Try then this link and you should see the NFT with no problems:
https://deploy-preview-775--wallet-develop-mainnet.netlify.app/evm/collectible-details?contract=0x63F8948c2Ee0670758A4E60EED80aAa6Cf093356&id=1141&tab=attributes
Checklist: