Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBC/README: Add description of jumper settings #10

Merged
merged 2 commits into from
May 24, 2020

Conversation

0cjs
Copy link
Contributor

@0cjs 0cjs commented Apr 28, 2020

Per issue #9.

@0cjs
Copy link
Contributor Author

0cjs commented May 19, 2020

@tebl Are there any issues with this preventing it from being merged?

@tebl
Copy link
Owner

tebl commented May 19, 2020 via email

@0cjs
Copy link
Contributor Author

0cjs commented May 19, 2020

Ok, no problem. If in the meantime you want to review this by just using the web interface to view the diff and the rendered version and asking me for changes (even trivial ones), I'm happy to do that. However, I've been working with the PDF export of the schematic because at the moment I'm unable to load the .sch file into KiCAD. (I'll have to work out at some point where my issue is with this.)

Copy link
Owner

@tebl tebl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAM_EN / ROM_EN are low when accessed by the system, jumper connects them with the glue logic. Otherwise, a good set of additions to the documentation.

@0cjs
Copy link
Contributor Author

0cjs commented May 20, 2020

Oh, good catch! I seem to have that error on the brain; I "fixed" that with bodge wires when building my SBC, too, which of course didn't work until I unfixed it.

I've pushed up a FIXUP commit so you can easily see the diff; I will squash (fixup in git rebase -i, actually) the two commits together after you've reviewed it. (Unfortunately GitHub doesn't let me change this PR to "not ready to merge" state, so be careful not to merge until I've squashed. :-))

@0cjs 0cjs force-pushed the dev/cjs/200428/sbc-jumpers branch from 9c0b2d2 to a983746 Compare May 20, 2020 01:09
@0cjs 0cjs requested a review from tebl May 24, 2020 02:16
@tebl tebl merged commit 9f70c83 into tebl:master May 24, 2020
@0cjs 0cjs deleted the dev/cjs/200428/sbc-jumpers branch May 24, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants