Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By introducing the monaco editor, which is part of VSCode, into apm, it will be possible to check the operation of new packages without using vscode.
The reason I chose monaco-react instead of monaco-editor itself is that it has a simple design that loads the webworker from a CDN. In exchange for the disadvantage of requiring web access to load the webworker, we can avoid complex webpack configuration, difficult errors, and numerous workarounds.
I struggled a lot to get the original monaco to work, but it was very difficult to get the webworker to work for release builds with the combination of electron and webpack. Debugging is very difficult because apm crashes immediately with a simple "unhandled undefiend" error in the log when starting apm.
The
'unsafe-inline'
option for style-src is unavoidable.https://github.com/microsoft/monaco-editor/issues/271
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: