Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data editor #1627

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add data editor #1627

wants to merge 4 commits into from

Conversation

mitosagi
Copy link
Collaborator

@mitosagi mitosagi commented Jan 5, 2024

Description

By introducing the monaco editor, which is part of VSCode, into apm, it will be possible to check the operation of new packages without using vscode.

The reason I chose monaco-react instead of monaco-editor itself is that it has a simple design that loads the webworker from a CDN. In exchange for the disadvantage of requiring web access to load the webworker, we can avoid complex webpack configuration, difficult errors, and numerous workarounds.

I struggled a lot to get the original monaco to work, but it was very difficult to get the webworker to work for release builds with the combination of electron and webpack. Debugging is very difficult because apm crashes immediately with a simple "unhandled undefiend" error in the log when starting apm.

The 'unsafe-inline' option for style-src is unavoidable. https://github.com/microsoft/monaco-editor/issues/271

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mitosagi mitosagi added the Type: new feature Suggesting new features label Jan 5, 2024
@mitosagi mitosagi requested a review from a team January 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: new feature Suggesting new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants