Upgrade yansi: 0.5.1 -> 1.0.1 #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adapt to `thing.paint(style)` API; was `style.paint(thing)` - Remove `yansi::Paint::enable_windows_ascii()` in style usage decision; removed in yansi commit b186eb5bfb, which introduced "automatic" support for Windows: "If support is not available, styling is disabled and no styling sequences are emitted", fitting the `Auto` option
niklasmohrin
approved these changes
Nov 9, 2024
Comment on lines
-252
to
-253
| #[cfg(target_os = "windows")] | ||
| let ansi_support = yansi::Paint::enable_windows_ascii(); |
There was a problem hiding this comment.
I suppose by https://docs.rs/yansi/1.0.1/yansi/index.html#windows we can omit this. Fair enough
There was a problem hiding this comment.
Yeah the commit message explained ;)
There was a problem hiding this comment.
Ah, I didn't see that, I'll make sure to include it in the merged commit
|
Cool! Do you know of any other dependencies updates we can do that would declutter the package index only requiring a patch-version bump? |
|
Not really, as least in Debian. Thanks for asking ;) |
| let enable_styles = match args.color.unwrap_or_default() { | ||
| // Attempt to use styling if instructed | ||
| ColorOptions::Always => true, | ||
| ColorOptions::Always => { | ||
| yansi::enable(); // disable yansi's automatic detection for ANSI support on Windows |
There was a problem hiding this comment.
@nc7s Sorry to bother you again, but how do you feel about this change I added? It should now be exactly the previous behavior right?
There was a problem hiding this comment.
I don't really know enough to judge this, from a glance LGTM?
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 19, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [dbrgn/tealdeer](https://github.com/dbrgn/tealdeer) | patch | `v1.7.0` -> `v1.7.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>dbrgn/tealdeer (dbrgn/tealdeer)</summary> ### [`v1.7.1`](https://github.com/dbrgn/tealdeer/blob/HEAD/CHANGELOG.md#v171-v171-2024-11-14) [Compare Source](tealdeer-rs/tealdeer@v1.7.0...v1.7.1) This patch release updates the `yansi` dependency to version 1, so that the previous versions of `yansi` can be removed from the package sets of Linux distributions. This change should not impact the behavior of tealdeer. Changes: - \[chore] Upgrade yansi: 0.5.1 -> 1.0.1 (\[[#​389](tealdeer-rs/tealdeer#389)]) Contributors to this version: - \[Blair Noctis]\[[@​nc7s](https://github.com/nc7s)] Thanks! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: https://github.com/SergioBenitez/yansi/releases/tag/v1.0.0
It'd be nice to have a version bump for this (patch level suffices), so I can straight update it in Debian rather than having to carry a patch ;)