Scopes: Re-purpose isScope as isFunctionScope for stack trace processing
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuend
changed the title
isScope as isFunctionScope for stack trace processingisScope as isFunctionScope for stack trace processing
|
@hbenl @takikawa @jridgewell Any thoughts on this one? I wasn't sure if it was blocking progress on the Scopes proposal implementations or not! |
|
The change seems fine, but I don't really have an opinion one way or the other because it doesn't affect the build-tooling side (only the consuming side). If @szuend thinks this makes consuming the ranges easier for dev-tools, then let's merge. |
copybara-service bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Sep 6, 2024
This CL aligns DevTools with an in-flight (but approved) spec PR: tc39/source-map#114. We need the flag to properly hide stack frames from stack traces that got inserted by transpilers and don't have a corresponding function in authored code. The flag also helps when dealing with inlining. R=kimanh@chromium.org Bug: 40277685 Change-Id: Iafef35e6ccdb0acf56b2fa91aafbdb44f03c6bce Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5836934 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
isScopetoisFunctionScope. The intention is to mark each generated range that is also something callable (functions, methods, arrow functions, accessors, constructors, ...). The purpose is twofold:range.isFunctionScope && !range.hasDefinition. See Scopes: support for hiding new injected scopes from the stack trace #113 for a detailed discussions and also why aisHiddenflag is not sufficient.Note that for 1. in particular this is a great boon for generators. If we don't have this flag then generators have to "mask" callsites for "hidden functions" instead. Which is a lot trickier especially if not all call-sites are known by a generator. Again, see #113 for an example/discussion.