ip/ipreassembler: fix positive header_delta push path #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is my merge correct? |
|
With the other patch merged, can you rebase? |
|
Yes, will give it a shot today.
~Derrick • iPhone
… On Nov 13, 2018, at 6:47 AM, Tom Barbette ***@***.***> wrote:
With the other patch merged, can you rebase?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
tbarbette
force-pushed
the
ipreassembler-push
branch
from
3bb1de9
to
028747d
Compare
|
I rebased myself. Can you verify I did not break the intent @pallas ? Thanks ! |
tbarbette
force-pushed
the
ipreassembler-push
branch
from
028747d
to
cdb13b6
Compare
Like the put earlier in this method, the push here can fail or reallocate the SKB. In the former case, we need to clean up (as above) and in both cases, we need to update the linkage into q from it's predecessor. Thanks: --enable-force-expensive + Valgrind Signed-off-by: Derrick Pallas <pallas@meraki.com>
tbarbette
force-pushed
the
ipreassembler-push
branch
from
cdb13b6
to
4b1f4ac
Compare
tbarbette
force-pushed
the
master
branch
2 times, most recently
from
b9c1853
to
b9f3521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the put earlier in this method, the push here can fail or reallocate
the SKB. In the former case, we need to clean up (as above) and in both
cases, we need to update the linkage into q from it's predecessor.
Thanks: --enable-force-expensive + Valgrind
Signed-off-by: Derrick Pallas pallas@meraki.com