Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change html response body check #62

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Change html response body check #62

merged 1 commit into from
Jun 26, 2024

Conversation

JorgeLeites
Copy link
Contributor

We received an error message that started like this:

<html>
  <head>
    <title>Object moved</title>
  </head>
  <body>
    <h2>Object moved to <a href="/page/254">here</a>.</h2>
  </body>
</html>

<!DOCTYPE html>

<html xmlns="http://www.w3.org/1999/xhtml">
  <head>
    <title>Rock - Page Not Found</title>
    ...

So, just checking for <!DOCTYPE html> wasn't catching it.

Also, now the code checks for Page Not Found in the body to throw a 404 error.

@JorgeLeites JorgeLeites force-pushed the jorge/T-12660-handle-rock-html-error-message branch from 2189ede to d6b6cc4 Compare June 25, 2024 14:21
@taylorbrooks taylorbrooks merged commit f1cc1c6 into taylorbrooks:master Jun 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorbrooks taylorbrooks taylorbrooks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorgeLeites @taylorbrooks