Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils #39

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add utils #39

wants to merge 6 commits into from

Conversation

Beanow
Copy link
Member

@Beanow Beanow commented Jun 27, 2022

Provides some handy utilities.
Sharing draft to get some thoughts on it.

  • Add ENV arguments to example, making it a portable utility we can use in other environments than cargo.
  • Add Docker test utility.

It should be invoked through .tests/hello-examples.sh.

  • Will need docker, docker-compose.
  • Xorg or Xwayland support (e.g. won't run on CI)

What it'll do is use an Ubuntu 18.04 container to build the example (as --release).
Then it should start up 4 containers,

  • no-library
  • libayatana
  • libappindicator
  • both-libs

Having different libraries installed as you would expect.
It should test crashes when lib is missing, and detection/fallback behavior.

This should let `dlopen` (through `ld.so`) handle what paths to search in for the respective libraries.

Additionally this fixes a mistake with the library filenames. Now using the `SONAME` instead of a symlinked name that happened to work when dev packages are installed.
Versions v0.7.1 and v0.7.2 relied exclusively on the .so files without .1 suffix.
This is 'bad' because by convention that signals we don't care about ABI compatibility.
However in weird cases (*ahum* Tauri bundled appimages) this .so file is the only one
available. Using this feature flag allows them some time to fix this problem and bundle
with the correct filename.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant