Skip to content

Commit

Permalink
chore: cleanup issue and PR templates (#48)
Browse files Browse the repository at this point in the history
* chore: cleanup issue and PR templates

* Delete .github/CONTRIBUTING.md

* Update bug_report.md

* Update feature_request.md

* Update PULL_REQUEST_TEMPLATE.md
  • Loading branch information
amrbashir authored Dec 15, 2023
1 parent d4f5991 commit c7cba5e
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 82 deletions.
44 changes: 0 additions & 44 deletions .github/CONTRIBUTING.md

This file was deleted.

4 changes: 0 additions & 4 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ If applicable, add screenshots to help explain your problem.
OS:
Rustc:

**Would you assign yourself to resolve this bug?**
- [ ] Yes
- [ ] No

**Additional context**
Add any other context about the problem here.

4 changes: 0 additions & 4 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Would you assign yourself to implement this feature?**
- [ ] Yes
- [ ] No

**Additional context**
Add any other context or screenshots about the feature request here.

45 changes: 15 additions & 30 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,36 +1,21 @@
<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/tauri-apps/tauri/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->
Before submitting a PR, please read https://github.com/tauri-apps/tauri/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
<!-- PULL REQUEST TEMPLATE -->
<!-- (Update "[ ]" to "[x]" to check a box) -->
1. Give the PR a descriptive title.
**What kind of change does this PR introduce?** (check at least one)
Examples of good title:
- fix: fix incorrect generated type
- docs: update docstrings
- feat: update bindings
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Documentation
- [ ] Build-related changes
- [ ] Other, please describe:
Examples of bad title:
- fix #7123
- update docs
- fix bugs
**Does this PR introduce a breaking change?** (check one)
<!--
If yes, please describe the impact and migration path for existing applications in an attached issue. Filing a PR with breaking changes that has not been discussed and approved by the maintainers in an issue will be immediately closed.
2. If there is a related issue, referenced in the PR text, e.g. closes #123.
3. If this change requires a new version, then add a change file in `.changes` directory with the appropriate bump, see https://github.com/tauri-apps/libappindicator-rs/blob/dev/.changes/readme.md
4. Ensure that all your commits are signed https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
5. Ensure `cargo test` and `cargo clippy` passes.
6. Open as a draft PR if your work is still in progress.
-->

- [ ] Yes. Issue #___
- [ ] No


**The PR fulfills these requirements:**

- [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix: #xxx[,#xxx]`, where "xxx" is the issue number)
- [ ] A change file is added if any packages will require a version bump due to this PR per [the instructions in the readme](https://github.com/tauri-apps/tauri/blob/dev/.changes/readme.md).

If adding a **new feature**, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**

0 comments on commit c7cba5e

Please sign in to comment.