Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tangle-cloud): Configure Layout, Network, and Wallet #2651

Merged
merged 42 commits into from
Nov 13, 2024

Conversation

AtelyPham
Copy link
Member

@AtelyPham AtelyPham commented Nov 12, 2024

Summary of changes

  • MAIN WORK: Establish a new library named tangle-shared-ui to facilitate the sharing of UI components and logic hooks between the Tangle dApp and Tangle Cloud.
  • Implement the layout, including a header, footer, and a sidebar for Tangle Cloud, featuring a dropdown menu for role selection.
  • Remove the hardcoded provider type from useSubstrateExplorerUrl to resolve an encoding issue that caused the dApp to freeze when connecting to the EVM wallet ae33481.
  • Incorporate a connected accounts check to ensure accounts are always available before initializing the Polkadot API db5fec2.
  • Add the missing target typed chain ID to the "try again" function to ensure proper wallet connectivity when users click on it dcd8bb4.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

CleanShot.2024-11-13.at.02.55.59.mp4

@AtelyPham AtelyPham added the needs review 👓 Pull request needs a review label Nov 12, 2024
@AtelyPham AtelyPham self-assigned this Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 7f7e3aa
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67342f29d5a3bf0007babe12
😎 Deploy Preview https://deploy-preview-2651--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 7f7e3aa
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67342f29a1eef90008f145cc
😎 Deploy Preview https://deploy-preview-2651--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

.husky/commit-msg Outdated Show resolved Hide resolved
.husky/pre-push Outdated Show resolved Hide resolved
apps/tangle-dapp/hooks/useSubstrateTx.ts Outdated Show resolved Hide resolved
libs/api-provider-environment/src/WebbProvider/index.tsx Outdated Show resolved Hide resolved
libs/tangle-shared-ui/src/types/bridge.ts Outdated Show resolved Hide resolved
libs/tangle-shared-ui/src/types/bridge.ts Outdated Show resolved Hide resolved
libs/tangle-shared-ui/src/types/bridge.ts Outdated Show resolved Hide resolved
@drewstone
Copy link
Contributor

Looks great @AtelyPham ! In the next PR let's turn the Operator Deployer purple button in the sidebar into a proper looking dropdown, right now it looks like a button. You can deviate from design if you have intuition something is off!

@drewstone drewstone merged commit 3ca9097 into develop Nov 13, 2024
15 checks passed
@drewstone drewstone deleted the trung-tin/wallet-connect-layout branch November 13, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 👓 Pull request needs a review
Projects
Status: Completed ✅
3 participants