Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tangle-dapp): Create LS Unbonding tab #2646

Merged
merged 15 commits into from
Nov 25, 2024
Merged

Conversation

yurixander
Copy link
Member

@yurixander yurixander commented Nov 11, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • ➕ Added an Unbonding tab to replace the unstaking requests table. This design is more consistent and fits right in with the tabs we have on the Liquid Staking page.
  • 🔧 Updated the unbond tx hook to use the lst pallet instead of the lstMinting previously being used.
  • 🐛 Fixed a bug in the commission calculation & display, where commission percentages were disproportionately large.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

ls-unbonding-table.mp4

@yurixander yurixander self-assigned this Nov 11, 2024
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 29c9023
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/6744a0f5f364c60008e0990e
😎 Deploy Preview https://deploy-preview-2646--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 29c9023
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/6744a0f5d17d8800083706d4
😎 Deploy Preview https://deploy-preview-2646--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yurixander yurixander marked this pull request as ready for review November 25, 2024 16:16
@drewstone drewstone merged commit c8828cb into develop Nov 25, 2024
15 checks passed
@drewstone drewstone deleted the yuri/ls-unbonding-tab branch November 25, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed ✅
2 participants