Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode extension is outdated #624

Open
Jasper-Bekkers opened this issue Jun 20, 2024 · 15 comments
Open

VSCode extension is outdated #624

Jasper-Bekkers opened this issue Jun 20, 2024 · 15 comments

Comments

@Jasper-Bekkers
Copy link

It looks like its still on 0.8.2 which is giving some team members grief because the formatting changed between the two versions causing team members on the vscode extension to have to manually revert files

@rami3l
Copy link

rami3l commented Jul 12, 2024

@tamasfe Looks like the publishing workflow of 4ba6c53 has failed? (4ba6c53#commitcomment-144072575)

@panekj
Copy link
Collaborator

panekj commented Jul 12, 2024

Yes

@panekj
Copy link
Collaborator

panekj commented Jul 15, 2024

I've published an update under my name, it might be still a bit bugged: https://marketplace.visualstudio.com/items?itemName=panekj.even-betterer-toml

@rami3l
Copy link

rami3l commented Aug 5, 2024

I've published an update under my name, it might be still a bit bugged: https://marketplace.visualstudio.com/items?itemName=panekj.even-betterer-toml

@panekj Thanks a lot for making this! Before @tamasfe responds, would you mind bumping that to bundle taplo-cli v0.9.3? Many thanks! 🙇

@panekj
Copy link
Collaborator

panekj commented Aug 6, 2024

I'd recommend configuring taplo as external LSP for now, as I'm still figuring out why the bundled LSP hates me.

in VSCode settings.json:

{
  "evenBetterToml.taplo.bundled": false,
  "evenBetterToml.taplo.path": "/home/pj/.cargo/bin/taplo",
  "evenBetterToml.taplo.extraArgs": []
}

@panekj panekj changed the title Update vscode extension to v0.9 VSCode extension is outdated Aug 16, 2024
@panekj panekj pinned this issue Aug 16, 2024
@nikhilweee
Copy link

Is there any way to manually install a new version of the extension until the new release gets published on vscode marketplace?

@redeboer
Copy link
Contributor

redeboer commented Oct 4, 2024

Thanks for publishing the temporary ("betterer" 😆) extension.
Could it be that that VS Code does not recognize it as a formatter? I've tried setting the following, but didn't help.

{
  "[toml]": {
    "editor.defaultFormatter": "panekj.even-betterer-toml"
  },
}

#624 (comment) also doesn't work.

@thernstig
Copy link
Contributor

thernstig commented Oct 31, 2024

I've published an update under my name, it might be still a bit bugged: https://marketplace.visualstudio.com/items?itemName=panekj.even-betterer-toml

Although this is appreciated, is there a plan to release the "real" extension? It will get confusing fast with temporary extensions published to fix intermediate problems.

VS Code shows the extension being quite outdated compare to the releases done for the CLI:
image

It seems @tamasfe is AWOL. @panekj Is he the only one with with rights to this repo to update the workflow to publish to Marketplace?

@panekj
Copy link
Collaborator

panekj commented Oct 31, 2024

Although this is appreciated, is there a plan to release the "real" extension?

I do not have access to VS Marketplace so I can't get a new token nor can I change it for CI since I do not have permissions to change repository settings. Until @tamasfe returns, the extension is frozen and cannot be modified.

Generally I think the original extension should work fine as long as external LSP is used but there might me some changes that affect extension only which are not included.

@thernstig
Copy link
Contributor

@panekj got it, that seems problematic. Hope @tamasfe comes back soon, but it has been 6 months soon, so maybe the only real solution is to eventually completely start a new repo and a new extension?

There are some updates that don't even relate to the CLI that I want, such as updates to package.json for the extension.

@panekj
Copy link
Collaborator

panekj commented Nov 6, 2024

0.21.0 is now published in Open-VSX and my (soft-)fork (https://github.com/panekj/taplo/releases/tag/release-even-better-toml-0.21.0) + VS Marketplace

I will try to get original extension deprecated to move people to fork until @tamasfe returns and updates the token, then we can revert it back.

@panekj
Copy link
Collaborator

panekj commented Nov 6, 2024

I'd recommend configuring taplo as external LSP for now, as I'm still figuring out why the bundled LSP hates me.

also, as of 0.21.0 this is fixed

@ssbarnea
Copy link

That should remind us that if we want a project to survive the test of time, we need to create it under an organization and ensure that there is at least one another individual that has full access to the "house keys".

@mathuin
Copy link

mathuin commented Nov 23, 2024

@panekj is there any chance you could upload your fork to https://open-vsx.org ? This would allow vscodium users like me to use it. Thank you in advance!

@panekj
Copy link
Collaborator

panekj commented Nov 23, 2024

@mathuin https://open-vsx.org/extension/tamasfe/even-better-toml is fully updated and there is no need for fork (open-vsx API tokens for uploading extensions don't expire like in Azure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants