Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: reformat all TOML files with taplo #3942

Merged
merged 3 commits into from
Jul 13, 2024
Merged

style: reformat all TOML files with taplo #3942

merged 3 commits into from
Jul 13, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jul 12, 2024 •
edited
Loading

rami3l
rami3l commented Jul 12, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@rami3l rami3l added this to the 1.28.0 milestone Jul 12, 2024
@rami3l rami3l requested review from rbtcollins and djc July 12, 2024 09:17
djc
djc reviewed Jul 12, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
smoelius
smoelius reviewed Jul 12, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@rami3l @smoelius
ci(gen-workflows): remove --quiet from git diff
f90ac8f 
Co-authored-by: Samuel Moelius <35515885+smoelius@users.noreply.github.com>
@rami3l rami3l requested a review from djc July 12, 2024 09:57
@rami3l rami3l force-pushed the chore/taplo branch 5 times, most recently from 1b2ef22 to 4a1f04b Compare July 12, 2024 10:39
@rami3l rami3l marked this pull request as draft July 13, 2024 02:57
djc
djc approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@djc djc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Suggest putting the reformatting commit before the one that adds the CI check.

@rami3l

This comment was marked as outdated.

Sign in to view
@djc

This comment was marked as outdated.

Sign in to view
@rami3l

This comment was marked as outdated.

Sign in to view
@rami3l rami3l marked this pull request as ready for review July 13, 2024 13:42
@rami3l rami3l enabled auto-merge July 13, 2024 13:47
@rami3l rami3l added this pull request to the merge queue Jul 13, 2024
@rami3l rami3l mentioned this pull request Jul 13, 2024
Closed
Merged via the queue into rust-lang:master with commit c6a9659 Jul 13, 2024
27 checks passed
@rami3l rami3l deleted the chore/taplo branch July 13, 2024 14:12
@rami3l
Copy link
Member Author

rami3l commented Jul 13, 2024 •
edited
Loading

@djc As there are a bit too many regressions/breakages in taplo v0.9, I've made the upgrade a separate follow-up issue in #3945. So far we are still using v0.8 for our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoelius smoelius smoelius left review comments

@djc djc djc approved these changes

@rbtcollins rbtcollins Awaiting requested review from rbtcollins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rami3l @djc @smoelius