Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): allow non-dev API endpoint roots #811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(clients): allow non-dev API endpoint roots #811

wants to merge 1 commit into from

Commits on Sep 11, 2024

  1. feat(clients): allow non-dev API endpoint roots 

    Specifying an API endpoint root to a client used to imply that the
endpoint in use was for dev, which would disable TLS and token bearer
authorisation. This is not always a valid assumption, for example when
manually specifying a locational endpoint for Google PubSub to target a
specific region, as such endpoints are for production and should
therefore use TLS and authorisation.

Fix this by allowing manual configuration of the `api_is_dev` setting
when using a non-dev root, whilst maintaining the old behaviour by
default for backwards compatibility.
    @w-miller
    w-miller committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6622d35 View commit details
    Browse the repository at this point in the history