Added option to display both absolute and percentage values in pie chart.

[MegaChriz]

Fixes #84.

[MegaChriz]

I see that the build is failing but I believe that the failure is a false positive.

Line   src/Chart/Pie.php                           

 ------ -------------------------------------------- 

  2353   Variable $Absolute might not be defined.    

  2356   Variable $Percentage might not be defined.  

  2359   Variable $Absolute might not be defined.    

  2359   Variable $Percentage might not be defined.

If you inspect the code clearly, then you can see that $Absolute and $Percentage always will have a value when they are used.

• $Absolute is defined when $WriteValues is PIE_VALUE_NATURAL or PIE_VALUE_BOTH. The variable isn't used later on if $WriteValues is something else.
• $Percentage is defined when $WriteValues is PIE_VALUE_PERCENTAGE or PIE_VALUE_BOTH. The variable isn't used later on if $WriteValues is something else.

But perhaps I could write the code differently, if desired. I think I would fix it by defining two additional methods.

[szymach]

Hello!
Thank you for your submission. I will have to consider this addition a bit, I think I will be able to do it this weekend. Cheers.

[MegaChriz]

Thanks for considering! Take the time you need. 🙂

[szymach]

Hello, sorry for late reply. Try the code below, it should silence any static code exceptions.

$ValidWriteValues = [PIE_VALUE_NATURAL, PIE_VALUE_PERCENTAGE, PIE_VALUE_BOTH];
if (false === in_array($WriteValues, $ValidWriteValues, true)) {
    return '';
}

$isBothOrNatural = in_array($WriteValues, [PIE_VALUE_NATURAL, PIE_VALUE_BOTH], true);
$isBothOrPercentage = in_array($WriteValues, [PIE_VALUE_PERCENTAGE, PIE_VALUE_BOTH], true);

$Absolute = true === $isBothOrNatural ? ($Value . $ValueSuffix) : null;
$Percentage = true === $isBothOrPercentage
    ? sprintf('%s%', round((100 / $SerieSum) * $Value, $Precision))
    : null
;

if (null === $Absolute && null === $Percentage) {
    throw new RuntimeException(
        "Neither absolute nor percentage display value was calculated"
        . " for display value \"{$WriteValues}\"."
    );
}

if (null !== $Absolute && null !== $Percentage) {
    $Result = "{$Absolute}\n({$Percentage})";
} elseif (null !== $Absolute) {
    $Result = $Absolute;
} elseif (null !== $Percentage) {
    $Result = $Percentage;
}

return $Result;

Also, can you please write a test case in this unit test for the new option?

[szymach]

Hello!
I am closing this PR, since I have incorporated Your code myself into the 3.1 branch. I will make a release sometime soon.

Cheers.