-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Upgrade to Material 3 design, refactor some core elements #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorry for such a huge number of changes in one PR, good luck future reviewer(s) 🥲 |
marking as draft until all issues will be fixed |
kuba2k2
force-pushed
the
feature/material3
branch
from
June 28, 2024 09:29
a903561
to
17fbecf
Compare
kuba2k2
force-pushed
the
feature/material3
branch
from
June 30, 2024 11:13
4d7444f
to
9cfd75b
Compare
kuba2k2
approved these changes
Jun 30, 2024
kuba2k2
changed the title
[ui + core] huge code update
[UI] Upgrade to Material 3 design, refactor some core elements
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #146
Replaces #196
Closes #179
Closes #162
Closes #131
Opens #202Credits
Important
One thing have been done, I've increased minSdk to 21.tools:overrideLibrary
wasn't working for me so I had to do this. If anybody knows a solution, you can review modifiedbuild.gradle
file.This is now fixed
What have been done
Removed dead codeReplaced deprecated methods with their alternativesWarning
I'll remove dead code & replace deprecated methods in another PR. (maybe)
However, I don't promise anything
Things required to merge this PR
implementation "com.github.sadorowo:NavLib:323288f"
->implementation "com.github.kuba2k2:NavLib:<new commit hash>"
Fix "Back button opens drawer" function, currently app is opening drawer and exiting. We need to prevent exiting.- doneConclusion
I'm not perfect in writing Android apps, especially in Kotlin/Java. Personally I prefer using Flutter because I often need to write multiplatform apps. However, I think the code is working fine.
Two things I've adjusted and I'm not sure about them:
1. data/api/edziennik/vulcan/data/VulcanHebe.kt:394I've set default filterType to BY_PUPIL, because if I wouldn't change it, thewhen
condition would be non-exhaustive. I've tested it and it works fine for me.edit: I misunderstood this code, now it's fixed
Basically, I've only changed two things. These changes were required because of the dependency upgrade.
First change
The
as MutableList
here is required becauseremoveAll
method which is used later doesn't exist for regularList
.Second change
I'm most unsure about this change.
WorkSpec.periodStartTime
doesn't exist in new version ofandroidx.work
, so I think this is the replacement for this calculation.Additional info
Original fork code is here.