Handle task timeout to send SIGTERM #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adri2000
force-pushed
the
acunin/task-timeout-sigterm
branch
from
de37e4d
to
3800f35
Compare
|
The unit tests need to be adapted to mock differently than before. subprocess.run was mocked, now it needs to be subprocess.Popen and potentially its functions. |
bpetermannS11
force-pushed
the
acunin/task-timeout-sigterm
branch
from
6f5fea2
to
b4741ac
Compare
Without this, Python subprocess sends SIGKILL on timeout, leaving no chance of graceful shutdown.
Need to mock subprocess.Popen and its wait method for pre-/post-boot tasks.
bpetermannS11
force-pushed
the
acunin/task-timeout-sigterm
branch
from
b4741ac
to
dd7f07a
Compare
oseiberts11
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, Python subprocess sends SIGKILL on timeout, leaving no chance of graceful shutdown.