Skip to content
This repository has been archived by the owner on Sep 16, 2020. It is now read-only.

adding tests #116

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

adding tests #116

wants to merge 29 commits into from

Conversation

dayoaws
Copy link

@dayoaws dayoaws commented Apr 16, 2018

adding tests to org.symphonyoss.client.events

pmonks and others added 20 commits March 12, 2018 13:59
Fix issue 104, this time in the CI environment as well as locally
Added Symphony Signals API support
Added javadoc comments, and signals example.
Improved test coverage.
@dayoaws dayoaws changed the title Develop adding tests Apr 16, 2018
@ftbb
Copy link
Collaborator

ftbb commented Apr 27, 2018

Sorry for the delay in responding, but there seems to be many updates to the code here I will need to review before accepting and potentially some commercial understanding on diffblue.

This software underpins many financial services bots in the market, so we are trying to make sure there are no impacts around these changes.

With that said, I'm really excited to have new contributors... hope to review shortly.

@dayoaws
Copy link
Author

dayoaws commented Apr 27, 2018

not a problem. the pull checks still show as not successful. is that because it doesn't refresh the checks?

@pmonks
Copy link
Contributor

pmonks commented May 17, 2018

@ftbb just confirming that @dayoaws does indeed have a CLA with the Foundation, and you should ignore the fact that the verification/cla-signed check is failing.

cc @copiesofcopies

ftbb and others added 5 commits May 22, 2018 07:37
…AiSpellParser-Tests-from-Diffblue-Deeptest

Add tests for client.ai.utils.AiSpellParser from Diffblue Deeptest
…clients for key and pods. This included adding get/set for SymAuth session/key http clients.
complete.
2. Set 'active' flag on SymUser when calling getAllUsersWithDetails().
blackrock-engineering and others added 3 commits July 26, 2018 10:29
@goleysunny
Copy link

Hi, I know this is very old. Is there any way to get a new release on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants