Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint damping gaussian's amplitudes are exchanged #6390

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

guilara
Copy link
Contributor

@guilara guilara commented Nov 28, 2024

Proposed changes

It seems to me that the amplitudes and widths for constraint damping are exchanged in the Inspiral yaml file. Object A should correspond to MassRight and viceversa. This will make a difference for unequal mass ratio evolutions.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@guilara guilara added bugfix small Only changes a few lines of code, does a rename or is otherwise quick to review labels Nov 28, 2024
@guilara guilara changed the title Constraint damping gaussians amplitudes are exchanged Constraint damping gaussian's amplitudes are exchanged Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix small Only changes a few lines of code, does a rename or is otherwise quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant