Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation with recent versions of doxygen #6384

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

kidder
Copy link
Member

@kidder kidder commented Nov 23, 2024

Proposed changes

Fix #5490

The first commit just updates the versions of files we use from the Doxygen Awesome CSS theme

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Doxygen layout files are dependent upon doxygen version.  There
was a breaking change in 1.9.8 to support c++ modules.  Doxygen
groups had been labeled as modules, but are now labeled as topics.
- Renamed layout.xml to DoxygenLayout_1_8_10.xml
- Added DoxygenLayout_1_9_8.xml
- Add switch between the two based on the version of doxygen
This file causes the sidebar to disappear for Doxygen versions
1.10.0 and higher.
This file apparently only made cosmetic changes to the documentation,
so we will try not using it, rather than spend the time trying to
fix it.
@kidder
Copy link
Member Author

kidder commented Nov 23, 2024

@wthrowe @ncorsobh please check that this works for you. I have not fixed all doxygen warnings for all versions; version 1.11.0 has no warnings for me.

Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, haven't tested it though

Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work with doxygen 1.12.0. I get a bunch of nonsensical warnings, but that's not a blocker. Example:

/home/wthrowe/tmp/host-docs/source/src/Evolution/Executables/Cce/KleinGordonCharacteristicExtract.hpp:125: warning: no uniquely matching class member found for 
  typedef EvolutionMetavars::factory_creation::tmpl::map< tmpl::pair< LtsTimeStepper, TimeSteppers::lts_time_steppers >, tmpl::pair< StepChooser< StepChooserUse::LtsStep >, cce_step_choosers >, tmpl::pair< StepChooser< StepChooserUse::Slab >, StepChoosers::standard_slab_choosers< system, local_time_stepping, false > >, tmpl::pair< TimeSequence< double >, TimeSequences::all_time_sequences< double > >, tmpl::pair< TimeSequence< std::uint64_t >, TimeSequences::all_time_sequences< std::uint64_t > >, tmpl::pair< Event, tmpl::list< Cce::Events::ObserveFields, Cce::Events::ObserveTimeStep > >, tmpl::pair< Trigger, tmpl::append< Triggers::logical_triggers, Triggers::time_triggers > > > factory_classes
Possible candidates:
  'T std::map::map(T... args)' at line 32548 of file /home/wthrowe/tmp/host-docs/source/docs/config/cppreference-doxygen-web.tag.xml
  'T std::pmr::map::map(T... args)' at line 37437 of file /home/wthrowe/tmp/host-docs/source/docs/config/cppreference-doxygen-web.tag.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doxygen 1.9.7 or later creates empty documentation html index
3 participants