Extrapolate from nearest element #6382
Open
+518
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
extrapolate_from_nearest_element
branch
2 times, most recently
from
f4f44f9
to
3ed9516
Compare
Uses the Lagrange basis in the nearest element to extrapolate into the excision region. This can be unstable when we want to extrapolate far into the excision because we're extrapolating over many logical element sizes. However, it can be useful for extrapolating only very slightly into the excision, e.g. if the excision in the initial data is the apparent horizon and the evolution needs a little space around it to find and track the horizon.
nilsvu
force-pushed
the
extrapolate_from_nearest_element
branch
from
3ed9516
to
482207f
Compare
wthrowe
requested changes
Nov 21, 2024
| @@ -65,10 +65,12 @@ std::optional<double> SphereTransition::original_radius_over_radius( | |||
| if ((original_radius + eps_) >= r_min_ and | |||
| (original_radius - eps_) <= r_max_) { | |||
| return std::optional<double>{original_radius / mag}; | |||
| } else if ((a_ > 0.0 and mag > r_max_) or (a_ < 0.0 and mag < r_min_)) { | |||
| } else if ((a_ > 0.0 and original_radius > r_max_) or | |||
| (a_ < 0.0 and original_radius < r_min_)) { | |||
There was a problem hiding this comment.
Is it easy to add a test for this?
| /// @} | ||
|
|
||
| /*! | ||
| * \brief Finds the block-logical coordinates of a point in an excision sphere. |
There was a problem hiding this comment.
This isn't showing up in the documentation. Maybe needs an \ingroup?
| if (radial_distance_this_block < 1.) { | ||
| continue; | ||
| } | ||
| // The checks above should leave only 1 valid block, so return that |
There was a problem hiding this comment.
Do we need to handle points on extrapolations of block boundaries?
| @@ -69,10 +71,32 @@ auto block_logical_coordinates( | |||
| const domain::FunctionsOfTimeMap& functions_of_time = {}) | |||
| -> std::vector<BlockLogicalCoords<Dim>>; | |||
|
|
|||
| /// \par Extrapolation | |||
There was a problem hiding this comment.
Doxygen does not seem to handle adding combining this with the documentation from the enclosing /// @{ group. Maybe \copydoc would work?
| {{domain::BlockId{4}, | ||
| // If the shape map preserved the BL-KS transformation within the | ||
| // excision, the result should be -1.5. However, apparently it | ||
| // doesn't. |
| os << "RadialAnchors"; | ||
| break; | ||
| default: | ||
| os << "Unknown"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Uses the Lagrange basis in the nearest element to extrapolate into the excision region. This can be unstable when we want to extrapolate far into the excision because we're extrapolating over many logical element sizes. However, it can be useful for extrapolating only very slightly into the excision, e.g. if the excision in the initial data is the apparent horizon and the evolution needs a little space around it to find and track the horizon.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments