Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accuracy of CoM integral #6377

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

iago-mendes
Copy link
Member

Proposed changes

This PR changes the center-of-mass surface integrand so that the results are analytically the same, but numerically more accurate. It reduces the round-off error that exists in the nature of this calculation (see the comments in CenterOfMass.hpp for more details).

The plots below show the CoM results for different outer boundary radii $R$ for both an isotropic Schwarzschild test and an equal-mass non-spinning BBH initial data. The different columns show some of the integrand variations that we tested. Given the simplicity of using $(\psi^4-1)$ and its significant improvement in the BBH case, that's the version being used in this PR.

distance_convergence_CoM_round_off_with_avg

distance_convergence-bbh

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

nilsvu
nilsvu previously approved these changes Nov 15, 2024
@nilsvu
Copy link
Member

nilsvu commented Nov 15, 2024

Doxygen is complaining

@iago-mendes
Copy link
Member Author

Thanks! I had not noticed that. Doxygen is working now.

@nilsvu nilsvu disabled auto-merge November 15, 2024 22:45
@nilsvu nilsvu merged commit ceeae05 into sxs-collaboration:develop Nov 15, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants