Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR changes the center-of-mass surface integrand so that the results are analytically the same, but numerically more accurate. It reduces the round-off error that exists in the nature of this calculation (see the comments in
CenterOfMass.hpp
for more details).The plots below show the CoM results for different outer boundary radii$R$ for both an isotropic Schwarzschild test and an equal-mass non-spinning BBH initial data. The different columns show some of the integrand variations that we tested. Given the simplicity of using $(\psi^4-1)$ and its significant improvement in the BBH case, that's the version being used in this PR.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments