Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write out BNS inertial centers for control system #6365

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Nov 6, 2024

Proposed changes

Now also writes out the inertial centers of the BNS from the control system along with the grid centers

Upgrade instructions

The grid centers of the BNS are now located in the /ControlSystems/BnsGridCenters subfile of the reductions H5 file, and the inertial centers are in the /ControlSystems/BnsInertialCenters subfile.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion. You can squash immediately.


const auto& blocks = domain.blocks();
std::vector<double> inertial_data_to_write{measurement_id.id};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an ASSERT(block_logical_coords.size() == 2, ..)? This would just help with making line 318 clearer. It should be true given only 2 things ever enter into the coords, but would ease readability, I think.

@nilsdeppe nilsdeppe merged commit f870a10 into sxs-collaboration:develop Nov 8, 2024
22 of 23 checks passed
@nilsdeppe
Copy link
Member

CI failure is random timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants