Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trigger StepsWithinSlab #6361

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Add trigger StepsWithinSlab #6361

merged 2 commits into from
Nov 6, 2024

Conversation

kidder
Copy link
Member

@kidder kidder commented Nov 4, 2024

Proposed changes

  • Add simple tag for StepNumberWithinSlab that counts the number of steps in each slab
  • Add trigger StepsWithinSlab which triggers based on the value of StepNumberWithinSlab

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@kidder
Add tag StepNumberWithinSlab
978b266 
This tag will be used to count steps within a slab.
Update the value of this tag in Actions::AdvanceTime.
This tag will enable making a Trigger that can be used for
triggering AMR within a Slab when using local time stepping.
@kidder
Add trigger that checks StepNumberWithinSlab
27b16e1
@wthrowe wthrowe merged commit a61c7e5 into sxs-collaboration:develop Nov 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wthrowe wthrowe wthrowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kidder @wthrowe