Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend sphere and wedge transition #6359

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Nov 1, 2024

Proposed changes

Allows the sphere and wedge shape map transition function to be extended outside the inner and outer radii/surfaces. This will be needed for BBH ringdown transition and also for extrapolating into excision spheres.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2
Copy link
Contributor Author

knelli2 commented Nov 5, 2024

@nilsvu Pushed a fixup for the Wedge transition as well

@knelli2 knelli2 changed the title Extend sphere transition Extend sphere and wedge transition Nov 7, 2024
nilsvu
nilsvu previously approved these changes Nov 7, 2024
@knelli2 knelli2 added the in progress Don't review, used for sharing code and getting feedback label Nov 13, 2024
@knelli2 knelli2 removed the in progress Don't review, used for sharing code and getting feedback label Nov 14, 2024
@knelli2
Copy link
Contributor Author

knelli2 commented Nov 14, 2024

@nilsvu Ok squashed in my fix and added a commit that will actually print a full numpy array if an input file test fails again.

)
raise AssertionError(
"Test data is not equal to the expected data"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raise the original exception

@nilsvu nilsvu merged commit a0a5f64 into sxs-collaboration:develop Nov 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants