-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend sphere and wedge transition #6359
Merged
nilsvu
merged 4 commits into
sxs-collaboration:develop
from
knelli2:extend_shape_transition
Nov 14, 2024
Merged
Extend sphere and wedge transition #6359
nilsvu
merged 4 commits into
sxs-collaboration:develop
from
knelli2:extend_shape_transition
Nov 14, 2024
+264
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
force-pushed
the
extend_shape_transition
branch
from
November 2, 2024 00:27
b8c8661
to
5fa391f
Compare
@nilsvu Pushed a fixup for the Wedge transition as well |
nilsvu
requested changes
Nov 5, 2024
src/Domain/CoordinateMaps/TimeDependent/ShapeMapTransitionFunctions/SphereTransition.cpp
Outdated
Show resolved
Hide resolved
src/Domain/CoordinateMaps/TimeDependent/ShapeMapTransitionFunctions/SphereTransition.cpp
Outdated
Show resolved
Hide resolved
src/Domain/CoordinateMaps/TimeDependent/ShapeMapTransitionFunctions/Wedge.cpp
Outdated
Show resolved
Hide resolved
src/Domain/CoordinateMaps/TimeDependent/ShapeMapTransitionFunctions/Wedge.cpp
Outdated
Show resolved
Hide resolved
src/Domain/CoordinateMaps/TimeDependent/ShapeMapTransitionFunctions/Wedge.cpp
Outdated
Show resolved
Hide resolved
src/Domain/CoordinateMaps/TimeDependent/ShapeMapTransitionFunctions/SphereTransition.cpp
Outdated
Show resolved
Hide resolved
knelli2
force-pushed
the
extend_shape_transition
branch
from
November 7, 2024 00:57
4adc140
to
434cf24
Compare
knelli2
force-pushed
the
extend_shape_transition
branch
from
November 7, 2024 03:44
434cf24
to
009998f
Compare
nilsvu
previously approved these changes
Nov 7, 2024
knelli2
added
the
in progress
Don't review, used for sharing code and getting feedback
label
Nov 13, 2024
knelli2
force-pushed
the
extend_shape_transition
branch
from
November 14, 2024 05:14
143ce19
to
7888678
Compare
knelli2
removed
the
in progress
Don't review, used for sharing code and getting feedback
label
Nov 14, 2024
@nilsvu Ok squashed in my fix and added a commit that will actually print a full numpy array if an input file test fails again. |
knelli2
force-pushed
the
extend_shape_transition
branch
from
November 14, 2024 20:00
7888678
to
607a458
Compare
nilsvu
reviewed
Nov 14, 2024
tools/CheckOutputFiles.py
Outdated
) | ||
raise AssertionError( | ||
"Test data is not equal to the expected data" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raise the original exception
knelli2
force-pushed
the
extend_shape_transition
branch
from
November 14, 2024 21:02
607a458
to
ee755cb
Compare
nilsvu
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allows the sphere and wedge shape map transition function to be extended outside the inner and outer radii/surfaces. This will be needed for BBH ringdown transition and also for extrapolating into excision spheres.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments