Allow three extra refinement levels for an ElementId #6347
Merged
+380
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
requested changes
Oct 22, 2024
src/Domain/Structure/SegmentId.cpp
Outdated
Comment on lines
15
to
17
| ASSERT(refinement_level < max_refinement_level, | ||
| ASSERT(refinement_level <= max_refinement_level, |
There was a problem hiding this comment.
Just remove this check. It's not a constraint on SegmentId but a constraint on ElementId
src/Domain/Structure/ElementId.cpp
Outdated
Comment on lines
16
to
20
| #if defined(__cpp_lib_int_pow2) && __cpp_lib_int_pow2 >= 202002L | ||
| #include <bit> | ||
| #else | ||
| #include "Utilities/StdHelpers/Bit.hpp" | ||
| #endif |
There was a problem hiding this comment.
This check should be in the Bit.hpp file. Nobody will know to do this magic when including that file.
nilsvu
previously approved these changes
Oct 24, 2024
nilsdeppe
reviewed
Oct 24, 2024
Some useful functions (std::has_single_bit and std::bit_floor) in the standard library bit are not defined until the version used by gcc10. So if they are not in the library we add implementations based on cppreference.com
This is done by using a compact representation of a SegmentId. Also fix some clang-tidy errors.
kidder
force-pushed
the
segment_id_bit_field
branch
from
03edcc9
to
cb46b8d
Compare
nilsdeppe
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by using a compact representation of a SegmentId. Also fix some clang-tidy errors.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments