Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop time step rejection #6250

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Fix infinite loop time step rejection #6250

merged 3 commits into from
Aug 27, 2024

Commits on Aug 26, 2024

  1. Remove clang-tidy AnalyzeTemporaryDtors option 

    Stopped doing anything in version 7.  New versions are starting to
complain.
    @wthrowe
    wthrowe committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    201f9d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Check that step size is changed on rejection 

    This catches a potential infinite loop.
    @wthrowe
    wthrowe committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    1168cfa View commit details
    Browse the repository at this point in the history

  2. Avoid roundoff trouble in choose_lts_step_size

    @wthrowe
    wthrowe committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    01388fa View commit details
    Browse the repository at this point in the history