Monte Carlo time stepping action #6198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
requested changes
Aug 27, 2024
| #include "Time/Time.hpp" | ||
| #include "Time/TimeStepId.hpp" | ||
|
|
||
| #include "Parallel/Printf/Printf.hpp" |
There was a problem hiding this comment.
remove? Leftover from debugging?
|
|
||
| namespace Particles::MonteCarlo { | ||
|
|
||
| // Mutator advancing neutrinos by a single step |
Comment on lines
74
to
82
| gsl::not_null<std::vector<Packet>*> packets, | ||
| gsl::not_null<std::mt19937*> random_number_generator, | ||
| gsl::not_null<std::array<DataVector, NeutrinoSpecies>*> | ||
| single_packet_energy, |
| explicit NeutrinoInteractionTable(CkMigrateMessage* msg) : PUP::able(msg) {} | ||
|
|
||
| using PUP::able::register_constructor; | ||
| void pup(PUP::er& p); |
There was a problem hiding this comment.
void pup(PUP::er& p) override;
ffoucart
force-pushed
the
MonteCarloTimeSteppingAction
branch
3 times, most recently
from
3ccd592
to
daebafe
Compare
ffoucart
force-pushed
the
MonteCarloTimeSteppingAction
branch
from
daebafe
to
f98ab56
Compare
|
Ok, I had missed a few initially, but I think now all comments have been addressed... |
ffoucart
force-pushed
the
MonteCarloTimeSteppingAction
branch
from
f98ab56
to
7c4eeb5
Compare
nilsdeppe
approved these changes
Aug 28, 2024
|
CI is timeout in Cylindrical BBH domain, which is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add an action to take a single MC time step, and a test of using this action within the mock run environment.
Only the last commit is actually relevant; all others are from PR #6138 , which is a prerequisite to this PR.
Upgrade instructions
None
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.