-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Apple Silicon on CI, simplify Apple Silicon installation instructions #5973
Upgrade to Apple Silicon on CI, simplify Apple Silicon installation instructions #5973
Conversation
d01d48b
to
039aeba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
MacOS spack installation of pybind11 isn't happy |
7129b4b
to
a39c58d
Compare
.github/workflows/Tests.yaml
Outdated
-D BUILD_PYTHON_BINDINGS=ON \ | ||
-D BOOTSTRAP_PY_DEPS=ON \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SetupPybind11.cmake
isn't finding the boostrapped pybind11. Maybe we need another hint in cmake?
4d4d782
to
c9d9218
Compare
2b186a7
to
2f4fecf
Compare
d925c24
to
f07dcf3
Compare
@geoffrey4444 FYI. Still needs #5956 to be merged first. |
a324de0
to
6362c38
Compare
I'm excited about adding Apple Silicon to the CI...thanks for doing this! I understand there are complexities to #5956 , so if that looks like it won't get merged for a while, maybe consider just implementing the slightly longer instructions in a separate PR, so we can start automatically checking Apple Silicon? We can always improve things later, but we have enough Apple Silicon users that it would be nice to get the CI up and running. But if $5956 is going to get merged soon-ish, maybe a separate PR isn't worth it. For those who prefer manual installation (I'm probably one of them, at least for now), maybe instead of deleting the longer instructions, move them down to a "manually install dependencies" section? |
b6e5388
to
428d3ea
Compare
@geoffrey4444 ok I removed the dependence on #5956 for now. Once it's merged we can simplify the instructions further, but I agree that it would be good to keep an (optional) "install manually" step. |
8b6cb08
to
e806e81
Compare
17a28c6
to
6fdfe6f
Compare
@nilsdeppe @geoffrey4444 @knelli2 I rebased and updated this. Please, could whoever of you is interested in this take another look so we can get this in? It would be helpful to have an ARM macOS build on CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look ok to me, but I don't have a mac to test.
-D CHARM_ROOT=${SPECTRE_DEPS_ROOT}/charm/multicore-darwin-arm8 \ | ||
-D SPECTRE_FETCH_MISSING_DEPS=ON \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's up to @geoffrey4444 if he wants the docs default to install extra dependencies in people's build directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fetching missing dependencies is fine
cc56424
to
e7fa645
Compare
LGTM, but I notice it has conflicts that must be resolved first |
e7fa645
to
cd0d990
Compare
Rebased! |
cd0d990
to
94d9c45
Compare
94d9c45
to
5dc55af
Compare
Tolerances on the partial derivative test still seem to not be adequate. |
No need for my approval on this. I was pinged in the past, but have nothing to add. |
This test failed on Intel macOS with OpenBLAS.
5dc55af
to
4c9c10b
Compare
Tolerances seem to work now @knelli2 |
Proposed changes
Upgrade the macOS CI test to run on Apple Silicon. Also simplify Apple Silicon installation instructions a bit.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments