Add member function observation_name to amr::Criteria

This will be used when observing the criteria.
sxs-collaboration · Nov 11, 2024 · 8e3634b · 8e3634b
1 parent bbc7c02
commit 8e3634b
Show file tree

Hide file tree

Showing 10 changed files with 22 additions and 0 deletions.
diff --git a/src/Elliptic/Systems/Punctures/AmrCriteria/RefineAtPunctures.hpp b/src/Elliptic/Systems/Punctures/AmrCriteria/RefineAtPunctures.hpp
@@ -43,6 +43,8 @@ class RefineAtPunctures : public amr::Criterion {
   WRAPPED_PUPable_decl_template(RefineAtPunctures);  // NOLINT
   /// \endcond
 
+  std::string observation_name() override { return "RefineAtPunctures"; }
+
   using argument_tags = tmpl::list<
       elliptic::Tags::Background<elliptic::analytic_data::Background>,
       domain::Tags::Domain<3>>;

diff --git a/src/ParallelAlgorithms/Amr/Criteria/Constraints.hpp b/src/ParallelAlgorithms/Amr/Criteria/Constraints.hpp
@@ -159,6 +159,8 @@ class Constraints : public Criterion {
                              Events::Tags::ObserverJacobianCompute<
                                  Dim, Frame::ElementLogical, Frame::Inertial>>>;
 
+  std::string observation_name() override { return "Constraints"; }
+
   using argument_tags = tmpl::list<::Tags::ObservationBox>;
 
   template <typename ComputeTagsList, typename DataBoxType,

diff --git a/src/ParallelAlgorithms/Amr/Criteria/Criterion.hpp b/src/ParallelAlgorithms/Amr/Criteria/Criterion.hpp
@@ -54,6 +54,8 @@ class Criterion : public PUP::able {
 
   WRAPPED_PUPable_abstract(Criterion);  // NOLINT
 
+  virtual std::string observation_name() = 0;
+
   /// Evaluates the AMR criteria by selecting the appropriate derived class
   /// and forwarding its `argument_tags` from the ObservationBox (along with the
   /// GlobalCache and ArrayIndex) to the call operator of the derived class

diff --git a/src/ParallelAlgorithms/Amr/Criteria/DriveToTarget.hpp b/src/ParallelAlgorithms/Amr/Criteria/DriveToTarget.hpp
@@ -78,6 +78,8 @@ class DriveToTarget : public Criterion {
   WRAPPED_PUPable_decl_template(DriveToTarget);  // NOLINT
   /// \endcond
 
+  std::string observation_name() override { return "DriveToTarget"; }
+
   using compute_tags_for_observation_box = tmpl::list<>;
 
   using argument_tags = tmpl::list<::domain::Tags::Mesh<Dim>>;

diff --git a/src/ParallelAlgorithms/Amr/Criteria/IncreaseResolution.hpp b/src/ParallelAlgorithms/Amr/Criteria/IncreaseResolution.hpp
@@ -35,6 +35,8 @@ class IncreaseResolution : public Criterion {
   WRAPPED_PUPable_decl_template(IncreaseResolution);  // NOLINT
   /// \endcond
 
+  std::string observation_name() override { return "IncreaseResolution"; }
+
   using compute_tags_for_observation_box = tmpl::list<>;
   using argument_tags = tmpl::list<>;
 

diff --git a/src/ParallelAlgorithms/Amr/Criteria/Loehner.hpp b/src/ParallelAlgorithms/Amr/Criteria/Loehner.hpp
@@ -177,6 +177,8 @@ class Loehner : public Criterion {
   WRAPPED_PUPable_decl_template(Loehner);  // NOLINT
   /// \endcond
 
+  std::string observation_name() override { return "Loehner"; }
+
   using compute_tags_for_observation_box = tmpl::list<>;
 
   using argument_tags = tmpl::list<::Tags::DataBox>;

diff --git a/src/ParallelAlgorithms/Amr/Criteria/Persson.hpp b/src/ParallelAlgorithms/Amr/Criteria/Persson.hpp
@@ -141,6 +141,8 @@ class Persson : public Criterion {
   WRAPPED_PUPable_decl_template(Persson);  // NOLINT
   /// \endcond
 
+  std::string observation_name() override { return "Persson"; }
+
   using compute_tags_for_observation_box = tmpl::list<>;
 
   using argument_tags = tmpl::list<::Tags::DataBox>;

diff --git a/src/ParallelAlgorithms/Amr/Criteria/Random.hpp b/src/ParallelAlgorithms/Amr/Criteria/Random.hpp
@@ -61,6 +61,8 @@ class Random : public Criterion {
   WRAPPED_PUPable_decl_template(Random);  // NOLINT
   /// \endcond
 
+  std::string observation_name() override { return "Random"; }
+
   using compute_tags_for_observation_box = tmpl::list<>;
 
   using argument_tags = tmpl::list<>;

diff --git a/src/ParallelAlgorithms/Amr/Criteria/TruncationError.hpp b/src/ParallelAlgorithms/Amr/Criteria/TruncationError.hpp
@@ -110,6 +110,8 @@ class TruncationError : public Criterion {
   WRAPPED_PUPable_decl_template(TruncationError);  // NOLINT
   /// \endcond
 
+  std::string observation_name() override { return "TruncationError"; }
+
   using compute_tags_for_observation_box = tmpl::list<>;
 
   using argument_tags = tmpl::list<::Tags::DataBox>;

diff --git a/tests/Unit/ParallelAlgorithms/Amr/Criteria/Test_Criterion.cpp b/tests/Unit/ParallelAlgorithms/Amr/Criteria/Test_Criterion.cpp
@@ -66,6 +66,8 @@ class CriterionOne : public amr::Criterion {
   using PUP::able::register_constructor;
   WRAPPED_PUPable_decl_template(CriterionOne);  // NOLINT
 
+  std::string observation_name() override { return "CriterionOne"; }
+
   using compute_tags_for_observartion_box = tmpl::list<>;
   using argument_tags = tmpl::list<FieldOne>;
 
@@ -108,6 +110,8 @@ class CriterionTwo : public amr::Criterion {
   using PUP::able::register_constructor;
   WRAPPED_PUPable_decl_template(CriterionTwo);  // NOLINT
 
+  std::string observation_name() override { return "CriterionTwo"; }
+
   using compute_tags_for_observartion_box = tmpl::list<ConstraintCompute>;
   using argument_tags = tmpl::list<Constraint>;