Skip to content

Commit

Permalink
Add tags to take MC step, size error
Browse files Browse the repository at this point in the history
  • Loading branch information
Francois Foucart committed Nov 1, 2024
1 parent 1bd140a commit 3f49648
Show file tree
Hide file tree
Showing 13 changed files with 200 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include "Evolution/Initialization/Evolution.hpp"
#include "Evolution/Initialization/Limiter.hpp"
#include "Evolution/Initialization/SetVariables.hpp"
#include "Evolution/Particles/MonteCarlo/Actions/InitializeMonteCarlo.hpp"
#include "Evolution/Particles/MonteCarlo/Actions/TimeStepActions.hpp"
#include "Evolution/Particles/MonteCarlo/GhostZoneCommunication.hpp"
#include "Evolution/Particles/MonteCarlo/GhostZoneCommunicationTags.hpp"
Expand Down Expand Up @@ -204,29 +205,37 @@ struct EvolutionMetavars {
evolution::dg::subcell::BackgroundGrVars<system, EvolutionMetavars,
true, false>>,
Actions::MutateApply<grmhd::ValenciaDivClean::subcell::SwapGrTags>,
Initialization::Actions::InitializeMCTags<system, EnergyBins,
NeutrinoSpecies>,
Initialization::Actions::AddComputeTags<tmpl::list<
Particles::MonteCarlo::InverseJacobianInertialToFluidCompute,
domain::Tags::JacobianCompute<4, Frame::Inertial, Frame::Fluid>>>,
// Initialization::TimeStepperHistory<EvolutionMetavars>
Parallel::Actions::TerminatePhase>;

using dg_element_array = DgElementArray<
EvolutionMetavars,
tmpl::list<
Parallel::PhaseActions<Parallel::Phase::Initialization,
initialization_actions>
//,
// Parallel::PhaseActions<
// Parallel::Phase::InitializeTimeStepperHistory,
// SelfStart::self_start_procedure<step_actions, system>>,
initialization_actions>,
//,
// Parallel::PhaseActions<
// Parallel::Phase::InitializeTimeStepperHistory,
// SelfStart::self_start_procedure<step_actions, system>>,

// Parallel::PhaseActions<Parallel::Phase::Register,
// tmpl::list<dg_registration_list,
// Parallel::Actions::TerminatePhase>>,
// Parallel::PhaseActions<Parallel::Phase::Register,
// tmpl::list<dg_registration_list,
// Parallel::Actions::TerminatePhase>>,

// Parallel::PhaseActions<
// Parallel::Phase::Evolve,
// tmpl::list<evolution::Actions::RunEventsAndTriggers,
// Actions::ChangeSlabSize, //step_actions,
// Actions::AdvanceTime,
// PhaseControl::Actions::ExecutePhaseChange>>>>;
Parallel::PhaseActions<
Parallel::Phase::Evolve,
tmpl::list<Particles::MonteCarlo::Actions::TakeTimeStep<
EnergyBins, NeutrinoSpecies>,
Parallel::Actions::TerminatePhase>>
// tmpl::list<evolution::Actions::RunEventsAndTriggers,
// Actions::ChangeSlabSize, //step_actions,
// Actions::AdvanceTime,
// PhaseControl::Actions::ExecutePhaseChange>>
>>;

struct registration
Expand Down
1 change: 1 addition & 0 deletions src/Evolution/Particles/MonteCarlo/Actions/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ spectre_target_headers(
${LIBRARY}
INCLUDE_DIRECTORY ${CMAKE_SOURCE_DIR}/src
HEADERS
InitializeMonteCarlo.hpp
TimeStepActions.hpp
)
133 changes: 133 additions & 0 deletions src/Evolution/Particles/MonteCarlo/Actions/InitializeMonteCarlo.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,133 @@
// Distributed under the MIT License.
// See LICENSE.txt for details.

#pragma once

#include <tuple>

#include "DataStructures/DataBox/DataBox.hpp"
#include "Domain/Tags.hpp"
#include "Evolution/Initialization/InitialData.hpp"
#include "Evolution/Particles/MonteCarlo/MortarData.hpp"
#include "Evolution/Particles/MonteCarlo/Packet.hpp"
#include "Evolution/Particles/MonteCarlo/Tags.hpp"
#include "Parallel/AlgorithmExecution.hpp"
#include "Parallel/GlobalCache.hpp"
#include "ParallelAlgorithms/Initialization/MutateAssign.hpp"
#include "Utilities/TMPL.hpp"

/// \cond
namespace tuples {
template <typename...>
class TaggedTuple;
} // namespace tuples

namespace Parallel {
template <typename Metavariables>
class GlobalCache;
} // namespace Parallel
/// \endcond

namespace Initialization::Actions {

/// \ingroup InitializationGroup
/// \brief Allocate variables needed for evolution of Monte Carlo transport
///
/// Uses:
/// - evolution::dg::subcell::Tags::Mesh<dim>
///
/// DataBox changes:
/// - Adds:
/// * Particles::MonteCarlo::Tags::PacketsOnElement
/// * Particles::MonteCarlo::Tags::RandomNumberGenerator
/// * Particles::MonteCarlo::Tags::DesiredPacketEnergyAtEmission
/// <NeutrinoSpecies>
/// * Particles::MonteCarlo::Tags::CellLightCrossingTime<DataVector>
/// * Background hydro variables
/// * Particles::MonteCarlo::Tags::MortarDataTag<dim>
///
/// - Removes: nothing
/// - Modifies: nothing
template <typename System, size_t EnergyBins, size_t NeutrinoSpecies>
struct InitializeMCTags {
public:
using hydro_variables_tag = typename System::hydro_variables_tag;

static constexpr size_t dim = System::volume_dim;
using simple_tags =
tmpl::list<Particles::MonteCarlo::Tags::PacketsOnElement,
Particles::MonteCarlo::Tags::RandomNumberGenerator,
Particles::MonteCarlo::Tags::DesiredPacketEnergyAtEmission<
NeutrinoSpecies>,
Particles::MonteCarlo::Tags::CellLightCrossingTime<DataVector>,
hydro_variables_tag,
Particles::MonteCarlo::Tags::MortarDataTag<dim>>;

using compute_tags = tmpl::list<>;

template <typename DbTagsList, typename... InboxTags, typename Metavariables,
typename ArrayIndex, typename ActionList,
typename ParallelComponent>
static Parallel::iterable_action_return_t apply(
db::DataBox<DbTagsList>& box,
const tuples::TaggedTuple<InboxTags...>& /*inboxes*/,
const Parallel::GlobalCache<Metavariables>& /*cache*/,
const ArrayIndex& /*array_index*/, ActionList /*meta*/,
const ParallelComponent* const /*meta*/) {
typename Particles::MonteCarlo::Tags::PacketsOnElement::type all_packets;
Initialization::mutate_assign<
tmpl::list<Particles::MonteCarlo::Tags::PacketsOnElement>>(
make_not_null(&box), std::move(all_packets));

// Currently seeds with 0 for testing...
typename Particles::MonteCarlo::Tags::RandomNumberGenerator::type rng(0);
Initialization::mutate_assign<
tmpl::list<Particles::MonteCarlo::Tags::RandomNumberGenerator>>(
make_not_null(&box), std::move(rng));

// Currently hard-code energy at emission; should be set by option
typename Particles::MonteCarlo::Tags::DesiredPacketEnergyAtEmission<
NeutrinoSpecies>::type packet_energy_at_emission;
for (size_t s = 0; s < NeutrinoSpecies; s++) {
packet_energy_at_emission[s] = 1.e-12;
}
Initialization::mutate_assign<
tmpl::list<Particles::MonteCarlo::Tags::DesiredPacketEnergyAtEmission<
NeutrinoSpecies>>>(make_not_null(&box),
std::move(packet_energy_at_emission));

// const double initial_time = db::get<::Tags::Time>(box);
const size_t num_grid_points =

Check failure on line 100 in src/Evolution/Particles/MonteCarlo/Actions/InitializeMonteCarlo.hpp

View workflow job for this annotation

GitHub Actions / Clang-tidy (Debug)

variable 'num_grid_points' is not initialized

Check failure on line 100 in src/Evolution/Particles/MonteCarlo/Actions/InitializeMonteCarlo.hpp

View workflow job for this annotation

GitHub Actions / Clang-tidy (Release)

variable 'num_grid_points' is not initialized
db::get<evolution::dg::subcell::Tags::Mesh<dim>>(box)

Check failure on line 101 in src/Evolution/Particles/MonteCarlo/Actions/InitializeMonteCarlo.hpp

View workflow job for this annotation

GitHub Actions / Clang-tidy (Debug)

no member named 'dg' in namespace 'evolution'

Check failure on line 101 in src/Evolution/Particles/MonteCarlo/Actions/InitializeMonteCarlo.hpp

View workflow job for this annotation

GitHub Actions / Clang-tidy (Release)

no member named 'dg' in namespace 'evolution'
.number_of_grid_points();
typename Particles::MonteCarlo::Tags::CellLightCrossingTime<
DataVector>::type cell_light_crossing_time(num_grid_points, 1.0);
Initialization::mutate_assign<tmpl::list<
Particles::MonteCarlo::Tags::CellLightCrossingTime<DataVector>>>(
make_not_null(&box), std::move(cell_light_crossing_time));

// const auto& inertial_coords =
// db::get<domain::Tags::Coordinates<dim, Frame::Inertial>>(box);
// Get hydro variables
using HydroVars = typename hydro_variables_tag::type;
HydroVars hydro_variables{num_grid_points, -1.0};
// Might need a more general initial data tag in the future
// hydro_variables.assign_subset(evolution::Initialization::initial_data(
// Parallel::get<::Tags::AnalyticSolutionOrData>(cache), inertial_coords,
// initial_time, typename hydro_variables_tag::tags_list{}));
Initialization::mutate_assign<tmpl::list<hydro_variables_tag>>(
make_not_null(&box), std::move(hydro_variables));

// Initialize empty mortar data; do we need more at initialization stage?
using MortarData =
typename Particles::MonteCarlo::Tags::MortarDataTag<dim>::type;
MortarData mortar_data;
Initialization::mutate_assign<
tmpl::list<Particles::MonteCarlo::Tags::MortarDataTag<dim>>>(
make_not_null(&box), std::move(mortar_data));

return {Parallel::AlgorithmExecution::Continue, std::nullopt};
}
};

} // namespace Initialization::Actions
28 changes: 22 additions & 6 deletions src/Evolution/Particles/MonteCarlo/Actions/TimeStepActions.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ struct TimeStepMutator {
Frame::Inertial>,
::Tags::deriv<gr::Tags::Shift<DataVector, Dim>, tmpl::size_t<Dim>,
Frame::Inertial>,
::Tags::deriv<gr::Tags::InverseSpatialMetric<DataVector, Dim>,
tmpl::size_t<Dim>, Frame::Inertial>,
::Tags::deriv<gr::Tags::SpatialMetric<DataVector, Dim>, tmpl::size_t<Dim>,
Frame::Inertial>,
gr::Tags::SpatialMetric<DataVector, Dim, Frame::Inertial>,
gr::Tags::InverseSpatialMetric<DataVector, Dim, Frame::Inertial>,
gr::Tags::DetSpatialMetric<DataVector>,
gr::Tags::SqrtDetSpatialMetric<DataVector>,
Particles::MonteCarlo::Tags::CellLightCrossingTime<DataVector>,
evolution::dg::subcell::Tags::Mesh<Dim>,
evolution::dg::subcell::Tags::Coordinates<Dim, Frame::ElementLogical>,
Expand Down Expand Up @@ -96,10 +96,10 @@ struct TimeStepMutator {

const tnsr::i<DataVector, Dim, Frame::Inertial>& d_lapse,
const tnsr::iJ<DataVector, Dim, Frame::Inertial>& d_shift,
const tnsr::iJJ<DataVector, Dim, Frame::Inertial>& d_inv_spatial_metric,
const tnsr::ijj<DataVector, Dim, Frame::Inertial>& d_spatial_metric,
const tnsr::ii<DataVector, Dim, Frame::Inertial>& spatial_metric,
const tnsr::II<DataVector, Dim, Frame::Inertial>& inv_spatial_metric,
const Scalar<DataVector>& determinant_spatial_metric,
const Scalar<DataVector>& sqrt_determinant_spatial_metric,
const Scalar<DataVector>& cell_light_crossing_time, const Mesh<Dim>& mesh,
const tnsr::I<DataVector, Dim, Frame::ElementLogical>& mesh_coordinates,
const std::optional<tnsr::I<DataVector, Dim, Frame::Inertial>>&
Expand Down Expand Up @@ -131,14 +131,30 @@ struct TimeStepMutator {
const DirectionalIdMap<Dim, std::optional<DataVector>>&
cell_light_crossing_time_ghost = mortar_data.cell_light_crossing_time;

tnsr::iJJ<DataVector, 3, Frame::Inertial> d_inv_spatial_metric =
make_with_value<tnsr::iJJ<DataVector, 3, Frame::Inertial>>(lapse, 0.0);
for (size_t i = 0; i < 3; i++) {
for (size_t j = i; j < 3; j++) {
for (size_t k = 0; k < 3; k++) {
for (size_t l = 0; l < 3; l++) {
for (size_t m = 0; m < 3; m++) {
d_inv_spatial_metric.get(k, i, j) -=
inv_spatial_metric.get(i, l) * inv_spatial_metric.get(j, m) *
d_spatial_metric.get(k, l, m);
}
}
}
}
}

TemplatedLocalFunctions<EnergyBins, NeutrinoSpecies> templated_functions;
templated_functions.take_time_step_on_element(
packets, random_number_generator, single_packet_energy, start_time,
end_time, equation_of_state, interaction_table, electron_fraction,
rest_mass_density, temperature, lorentz_factor,
lower_spatial_four_velocity, lapse, shift, d_lapse, d_shift,
d_inv_spatial_metric, spatial_metric, inv_spatial_metric,
determinant_spatial_metric, cell_light_crossing_time, mesh,
sqrt_determinant_spatial_metric, cell_light_crossing_time, mesh,
mesh_coordinates, num_ghost_zones, mesh_velocity,
inverse_jacobian_logical_to_inertial, det_jacobian_logical_to_inertial,
inertial_to_fluid_jacobian, inertial_to_fluid_inverse_jacobian,
Expand Down
4 changes: 2 additions & 2 deletions src/Evolution/Particles/MonteCarlo/CellVolume.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ namespace Particles::MonteCarlo {
void cell_proper_four_volume_finite_difference(
const gsl::not_null<Scalar<DataVector>*> cell_proper_four_volume,
const Scalar<DataVector>& lapse,
const Scalar<DataVector>& determinant_spatial_metric,
const Scalar<DataVector>& sqrt_determinant_spatial_metric,
const double time_step, const Mesh<3>& mesh,
const Scalar<DataVector>& det_jacobian_logical_to_inertial) {
const double cell_logical_volume =
8.0 / static_cast<double>(mesh.number_of_grid_points());
cell_proper_four_volume->get() =
get(lapse) * get(determinant_spatial_metric) * time_step *
get(lapse) * get(sqrt_determinant_spatial_metric) * time_step *
cell_logical_volume * get(det_jacobian_logical_to_inertial);
}

Expand Down
11 changes: 5 additions & 6 deletions src/Evolution/Particles/MonteCarlo/CellVolume.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,11 @@ namespace Particles::MonteCarlo {
/// in inertial coordinates, hence the need for
/// det_jacobian_logical_to_inertial
void cell_proper_four_volume_finite_difference(
gsl::not_null<Scalar<DataVector>* > cell_proper_four_volume,
const Scalar<DataVector>& lapse,
const Scalar<DataVector>& determinant_spatial_metric,
double time_step,
const Mesh<3>& mesh,
const Scalar<DataVector>& det_jacobian_logical_to_inertial);
gsl::not_null<Scalar<DataVector>*> cell_proper_four_volume,
const Scalar<DataVector>& lapse,
const Scalar<DataVector>& sqrt_determinant_spatial_metric, double time_step,
const Mesh<3>& mesh,
const Scalar<DataVector>& det_jacobian_logical_to_inertial);

/// 3-volume of a cell in inertial coordinate. Note that this is
/// the coordinate volume, not the proper volume. This quantity
Expand Down
3 changes: 2 additions & 1 deletion src/Evolution/Particles/MonteCarlo/System.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ struct System {
hydro::Tags::RestMassDensity<DataVector>,
hydro::Tags::ElectronFraction<DataVector>,
hydro::Tags::Temperature<DataVector>,
hydro::Tags::LowerSpatialFourVelocity<DataVector, 3, Frame::Inertial>>>;
hydro::Tags::LowerSpatialFourVelocity<DataVector, 3, Frame::Inertial>,
hydro::Tags::SpatialVelocity<DataVector, 3>>>;
using primitive_variables_tag =
hydro_variables_tag; //::Tags::Variables<tmpl::list<>>;

Expand Down
2 changes: 1 addition & 1 deletion src/Evolution/Particles/MonteCarlo/Tags.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ struct InteractionRatesTable : db::SimpleTag {
std::unique_ptr<NeutrinoInteractionTable<EnergyBins, NeutrinoSpecies>>;
static constexpr bool pass_metavariables = false;
using option_tags =
NeutrinoInteractionTable<EnergyBins, NeutrinoSpecies>::options;
typename NeutrinoInteractionTable<EnergyBins, NeutrinoSpecies>::options;
static type create_from_options(const std::string filename) {
std::unique_ptr<Particles::MonteCarlo::NeutrinoInteractionTable<
EnergyBins, NeutrinoSpecies>>
Expand Down
6 changes: 3 additions & 3 deletions src/Evolution/Particles/MonteCarlo/TakeTimeStep.tpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void TemplatedLocalFunctions<EnergyBins, NeutrinoSpecies>::
const tnsr::iJJ<DataVector, 3, Frame::Inertial>& d_inv_spatial_metric,
const tnsr::ii<DataVector, 3, Frame::Inertial>& spatial_metric,
const tnsr::II<DataVector, 3, Frame::Inertial>& inv_spatial_metric,
const Scalar<DataVector>& determinant_spatial_metric,
const Scalar<DataVector>& sqrt_determinant_spatial_metric,
const Scalar<DataVector>& cell_light_crossing_time,

const Mesh<3>& mesh,
Expand Down Expand Up @@ -137,8 +137,8 @@ void TemplatedLocalFunctions<EnergyBins, NeutrinoSpecies>::
Scalar<DataVector> cell_inertial_three_volume =
make_with_value<Scalar<DataVector>>(lapse, 0.0);
cell_proper_four_volume_finite_difference(
&cell_proper_four_volume, lapse, determinant_spatial_metric, time_step,
mesh, det_jacobian_logical_to_inertial);
&cell_proper_four_volume, lapse, sqrt_determinant_spatial_metric,
time_step, mesh, det_jacobian_logical_to_inertial);
cell_inertial_coordinate_three_volume_finite_difference(
&cell_inertial_three_volume, mesh, det_jacobian_logical_to_inertial);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ struct TemplatedLocalFunctions {
const tnsr::iJJ<DataVector, 3, Frame::Inertial>& d_inv_spatial_metric,
const tnsr::ii<DataVector, 3, Frame::Inertial>& spatial_metric,
const tnsr::II<DataVector, 3, Frame::Inertial>& inv_spatial_metric,
const Scalar<DataVector>& determinant_spatial_metric,
const Scalar<DataVector>& sqrt_determinant_spatial_metric,
const Scalar<DataVector>& cell_light_crossing_time, const Mesh<3>& mesh,
const tnsr::I<DataVector, 3, Frame::ElementLogical>& mesh_coordinates,
size_t num_ghost_zones,
Expand Down
6 changes: 3 additions & 3 deletions tests/Unit/Evolution/Particles/MonteCarlo/Test_CellVolume.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@ SPECTRE_TEST_CASE("Unit.Evolution.Particles.MonteCarloCellVolume",
const size_t dv_size = 27;
DataVector zero_dv(dv_size, 0.0);
Scalar<DataVector> lapse{DataVector(dv_size, 1.2)};
Scalar<DataVector> determinant_spatial_metric{DataVector(dv_size, 0.9)};
Scalar<DataVector> sqrt_determinant_spatial_metric{DataVector(dv_size, 0.9)};

Check failure on line 20 in tests/Unit/Evolution/Particles/MonteCarlo/Test_CellVolume.cpp

View workflow job for this annotation

GitHub Actions / Clang-tidy (Debug)

variable 'sqrt_determinant_spatial_metric' of type 'Scalar<DataVector>' (aka 'Tensor<DataVector, list<>, list<>>') can be declared 'const'

Check failure on line 20 in tests/Unit/Evolution/Particles/MonteCarlo/Test_CellVolume.cpp

View workflow job for this annotation

GitHub Actions / Clang-tidy (Release)

variable 'sqrt_determinant_spatial_metric' of type 'Scalar<DataVector>' (aka 'Tensor<DataVector, list<>, list<>>') can be declared 'const'
Scalar<DataVector> det_jacobian_logical_to_inertial{DataVector(dv_size, 1.1)};
const double time_step = 0.6;

Scalar<DataVector> cell_proper_four_volume{DataVector(dv_size, 0.0)};
Scalar<DataVector> expected_cell_proper_four_volume{
DataVector(dv_size, 8.0 / 27.0 * 1.2 * 0.9 * 0.6 * 1.1)};
Particles::MonteCarlo::cell_proper_four_volume_finite_difference(
&cell_proper_four_volume, lapse, determinant_spatial_metric, time_step,
mesh, det_jacobian_logical_to_inertial);
&cell_proper_four_volume, lapse, sqrt_determinant_spatial_metric,
time_step, mesh, det_jacobian_logical_to_inertial);

Scalar<DataVector> cell_inertial_three_volume{DataVector(dv_size, 0.0)};
Scalar<DataVector> expected_cell_inertial_three_volume{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ void test_flat_space_time_step(const bool skip) {
spatial_metric.get(0, 0) = 1.0;
spatial_metric.get(1, 1) = 1.0;
spatial_metric.get(2, 2) = 1.0;
Scalar<DataVector> determinant_spatial_metric(dv_size, 1.0);
Scalar<DataVector> sqrt_determinant_spatial_metric(dv_size, 1.0);

Check failure on line 61 in tests/Unit/Evolution/Particles/MonteCarlo/Test_TakeTimeStep.cpp

View workflow job for this annotation

GitHub Actions / Clang-tidy (Debug)

variable 'sqrt_determinant_spatial_metric' of type 'Scalar<DataVector>' (aka 'Tensor<DataVector, list<>, list<>>') can be declared 'const'

Check failure on line 61 in tests/Unit/Evolution/Particles/MonteCarlo/Test_TakeTimeStep.cpp

View workflow job for this annotation

GitHub Actions / Clang-tidy (Release)

variable 'sqrt_determinant_spatial_metric' of type 'Scalar<DataVector>' (aka 'Tensor<DataVector, list<>, list<>>') can be declared 'const'
tnsr::I<DataVector, 3, Frame::Inertial> shift =
make_with_value<tnsr::I<DataVector, 3, Frame::Inertial>>(lapse, 0.0);
tnsr::i<DataVector, 3, Frame::Inertial> d_lapse =
Expand Down Expand Up @@ -244,7 +244,7 @@ void test_flat_space_time_step(const bool skip) {
electron_fraction, baryon_density, temperature, lorentz_factor,
lower_spatial_four_velocity, lapse, shift, d_lapse, d_shift,
d_inv_spatial_metric, spatial_metric, inv_spatial_metric,
determinant_spatial_metric, cell_light_crossing_time, mesh,
sqrt_determinant_spatial_metric, cell_light_crossing_time, mesh,
mesh_coordinates, num_ghost_zones, mesh_velocity,
inverse_jacobian_logical_to_inertial, det_jacobian_logical_to_inertial,
jacobian_inertial_to_fluid, inverse_jacobian_inertial_to_fluid,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ void test_advance_packets(const bool skip) {
spatial_metric.get(0, 0) = 1.0;
spatial_metric.get(1, 1) = 1.0;
spatial_metric.get(2, 2) = 1.0;
Scalar<DataVector> determinant_spatial_metric(n_pts, 1.0);
Scalar<DataVector> sqrt_determinant_spatial_metric(n_pts, 1.0);
tnsr::I<DataVector, 3, Frame::Inertial> shift =
make_with_value<tnsr::I<DataVector, 3, Frame::Inertial>>(lapse, 0.0);
tnsr::i<DataVector, 3, Frame::Inertial> d_lapse =
Expand Down Expand Up @@ -320,7 +320,7 @@ void test_advance_packets(const bool skip) {
d_inv_spatial_metric,
spatial_metric,
inv_spatial_metric,
determinant_spatial_metric,
sqrt_determinant_spatial_metric,
mesh_coordinates,
mesh_velocity,
inverse_jacobian_logical_to_inertial,
Expand Down

0 comments on commit 3f49648

Please sign in to comment.