Skip to content

Commit

Permalink
Merge branch 'main' into gysimichael-patch-1
Browse files Browse the repository at this point in the history
  • Loading branch information
danjov authored Nov 29, 2023
2 parents 883639a + b91ae83 commit 85a785b
Show file tree
Hide file tree
Showing 12 changed files with 224 additions and 1,247 deletions.
24 changes: 24 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

---

**Steps to reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Current behavior**
A clear and concise description of what the bug is.

**Screenshots**
If applicable, add screenshots to help explain your problem.
9 changes: 7 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Setup .NET
uses: actions/setup-dotnet@v2
with:
dotnet-version: 6.0.x

- name: Build solution
run: dotnet build BDMS.sln -c Release /warnaserror

Expand All @@ -59,9 +64,9 @@ jobs:
run: npm ci

- name: Cypress run
uses: cypress-io/github-action@v5
uses: cypress-io/github-action@v6
with:
command: npx cypress-cloud run --record --parallel --key ${{ secrets.CURRENTS_RECORD_KEY }} --ci-build-id ${{ github.repository }}-${{ github.run_id }}-${{ github.run_attempt}}
command: npx cypress run --record --parallel --key ${{ secrets.CYPRESS_RECORD_KEY }} --ci-build-id ${{ github.repository }}-${{ github.run_id }}-${{ github.run_attempt}}
build: npm run build
start: npm start
wait-on: 'http://localhost:3000'
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ Damit auf dem Entwicklungsrechner keine Frameworks (Python, .NET, Node) installi

## Cypress Tests

Die Cypress Tests können mit `npm run cy` oder `npm run test` gestartet werden. Sie werden zudem automatisch in der CI/CD Pipeline ausgeführt. Das Projekt ist mit [Currents](https://currents.dev/) konfiguriert, wodurch unter anderem die parallele Ausführung der End-to-End (E2E) Tests ermöglicht wird. Testergebnisse und Aufzeichnungen sind ebenfalls direkt in [Currents](https://currents.dev/) einsehbar, was die Identifikation und Behebung möglicher Fehler und Probleme erleichtert. Um die detaillierten Testergebnisse einzusehen und die E2E-Tests des Projekts zu debuggen, kann die [Currents Dashboard-Seite](https://app.currents.dev/projects/zNEaVK/runs) besucht werden.
Die Cypress Tests können mit `npm run cy` oder `npm run test` gestartet werden. Sie werden zudem automatisch in der CI/CD Pipeline ausgeführt. Das Projekt ist mit [Cypress Cloud](https://cloud.cypress.io/) konfiguriert, wodurch unter anderem die parallele Ausführung der End-to-End (E2E) Tests ermöglicht wird. Testergebnisse und Aufzeichnungen sind ebenfalls direkt in [Cypress Cloud](https://currents.dev/) einsehbar, was die Identifikation und Behebung möglicher Fehler und Probleme erleichtert. Um die detaillierten Testergebnisse einzusehen und die E2E-Tests des Projekts zu debuggen, kann die [Cypress Dashboard-Seite](https://cloud.cypress.io/projects/gv8yue/runs) besucht werden.
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ services:
volumes:
- ./data/minio:/data
entrypoint: sh
command: -c 'mkdir -p /data/CANNONFLEA && /opt/bin/minio server /data -console-address ":9002"'
command: -c 'mkdir -p /data/cannonflea && /usr/bin/minio server /data -console-address ":9002"'
ports:
- 9000:9000
db:
Expand Down
2 changes: 1 addition & 1 deletion src/api-legacy/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ asyncpg==0.24.0
dateutils==0.6.8
tornado==6.1
PyPDF2==1.27.5
reportlab==3.5.55
reportlab==3.6.13
pyshp==2.1.0
svglib==1.0.0
svg2rlg==0.3
Expand Down
4 changes: 3 additions & 1 deletion src/api/BoreholeFileUploadService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ public BoreholeFileUploadService(BdmsContext context, IConfiguration configurati
this.httpContextAccessor = httpContextAccessor;
this.context = context;
this.s3Client = s3Client;
bucketName = configuration["S3:BUCKET_NAME"];
#pragma warning disable CA1308
bucketName = configuration["S3:BUCKET_NAME"].ToLowerInvariant();
#pragma warning restore CA1308
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/api/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ WORKDIR /src
# Install missing packages
RUN apt-get -y update
RUN apt-get -y install git vim curl htop
RUN dotnet tool install --global dotnet-ef
RUN dotnet tool install --global dotnet-ef --version 6.0.7
ENV PATH $PATH:/root/.dotnet/tools

# Restore dependencies and tools
Expand Down
3 changes: 0 additions & 3 deletions src/client/currents.config.js

This file was deleted.

6 changes: 3 additions & 3 deletions src/client/cypress.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const { defineConfig } = require("cypress");
const { cloudPlugin } = require("cypress-cloud/plugin");

module.exports = defineConfig({
projectId: "gv8yue",
e2e: {
baseUrl: "http://localhost:3000",
video: false,
Expand All @@ -25,9 +25,9 @@ module.exports = defineConfig({

return launchOptions;
});

return cloudPlugin(on, config);
},
},
defaultCommandTimeout: 10000,
waitForAnimations: false,
animationDistanceThreshold: 50,
});
Loading

0 comments on commit 85a785b

Please sign in to comment.