Skip to content

Commit

Permalink
Libs(JS): downgrade @stablelib/base64 avoiding ERR_REQUIRE_ESM (#…
Browse files Browse the repository at this point in the history
…1506)

Fixes #1505

Big thanks to @ZONGMENG-kaito for the report.

During the work on #1480
various dependencies were updated to match what is being produced by the
upstream code generator. Unfortunately, the version spec change for
`@stablelib/base64` up to 2.x means we inherit their ESM requirement.

The local tests (i.e. `SVIX_SERVER_URL=... SVIX_TOKEN=... yarn test`)
continue to pass with the downgrade, so it seems like pinning to 1.x
will free consumers of _our lib_ of this new requirement for now.

Hopefully in the future we'll find a way to track 2.x without
disruption.
  • Loading branch information
svix-onelson authored Nov 7, 2024
2 parents 03809ac + 05d93d2 commit fed1266
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"lint:fix": "yarn run lint:prettier --write && yarn run lint:eslint --fix"
},
"dependencies": {
"@stablelib/base64": "^2.0.0",
"@stablelib/base64": "^1.0.0",
"@types/node": "^22.7.5",
"es6-promise": "^4.2.8",
"fast-sha256": "^1.3.0",
Expand Down
8 changes: 4 additions & 4 deletions javascript/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -629,10 +629,10 @@
dependencies:
"@sinonjs/commons" "^3.0.0"

"@stablelib/base64@^2.0.0":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@stablelib/base64/-/base64-2.0.0.tgz#f13a98549cd5ca0750cd177bbd08b599d24e5f8e"
integrity sha512-ffSfySa1ZpZYzM5FQ2xILQ2jifQ+GlgbDJzRTCtaB0sqta88KYghB/tlSV2VS2iHRCvMdUvJlLOW1rmSkziWnw==
"@stablelib/base64@^1.0.0":
version "1.0.1"
resolved "https://registry.yarnpkg.com/@stablelib/base64/-/base64-1.0.1.tgz#bdfc1c6d3a62d7a3b7bbc65b6cce1bb4561641be"
integrity sha512-1bnPQqSxSuc3Ii6MhBysoWCg58j97aUjuCSZrGSmDxNqtytIi0k8utUenAwTZN4V5mXXYGsVUI9zeBqy+jBOSQ==

"@stablelib/utf8@^2.0.0":
version "2.0.0"
Expand Down

0 comments on commit fed1266

Please sign in to comment.