fix: Use default cookie decoder instead of bare native #13037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvelteKit currently depends on cookie@0.6.0 which has known security vulnerability. User can create an override if they do not need to keep the backward compatibility. cookie@0.6.0 wraps the passed decoder in try..catch but the new version does not. When overriding, the `cookies.get` will throw if passed in cookie contains malformed content. In both cases the default `decode` of `cookie` library also has small performance optimization so removing the passing of decodeURIComponent should be win already.
🦋 Changeset detectedLatest commit: 9403593 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
Nov 21, 2024
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
benmccann
reviewed
Nov 21, 2024
benmccann
reviewed
Nov 21, 2024
benmccann
reviewed
Nov 21, 2024
benmccann
approved these changes
Nov 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SvelteKit currently depends on cookie@0.6.0 which has known security vulnerability. User can create an override if they do not need to keep the backward compatibility.
cookie@0.6.0 wraps the passed decoder in try..catch but the new version does not. If user overrides the cookie library,
cookies.getandcookies.getAllthrow if called with a cookie value that contains malformed content.In both cases (cookie@0.6.0 and higher) the default
decodeimplementation ofcookielibrary has performance optimization to skip callingdecodeURIComponentif the string does not contain"%".Removing the passing of default decoder:
decodeURIComponentdoes not harm but helps both cases.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits