-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to sveltekit vite project to adjust root #13027
Conversation
🦋 Changeset detectedLatest commit: 888dffa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13027-svelte.vercel.app/ this is an automated message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems from #12499 (comment) that you're arguing we should respect the options in the Vite config. But if that's so, then I would expect root
to be read from the Vite config (https://vite.dev/config/shared-options.html#root) instead of specified in a new location. It's already hard enough that we have a Svelte config and Vite config. I don't particularly want to add a third location to specify configuration options
I mean yeah, ideally, but it's beyond my capabilities to get that working, so this is at least something simple that does work... If you are capable of properly fixing it, it'd definitely be better. |
Well there's 745 open issues, so it's not likely I'll get to that particular one But I'm afraid I'm going to have to close this given the approach |
Doesn't really help (the already pretty terrible) dev experience when getting an actual production application to properly work... Gotta say the more I use it it seems that svelte is really just designed to be used as a demo framework to get a prototype onto vercel, once you go only slightly off that path it seems nobody actually tested anything... You actually want a proper maintainable architecture? Use turborepo, except it doesn't have any concept of dependencies... Well then use trusty ol' NX? Well this happens. How are you actually supposed to work with this? |
Hey @benmccann. Is there any direction you are thinking of? I don't know If I can be of direct help, but I'm willing to put in some hours in December, to get to know how this works. |
Properly fixes #12499 (or at least hotfixes it).
Just provides an option to change the root as svelte ignores vite's root setting...
No idea how to write a test for this with the current setup.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits