fix: check a constructor exists before instantiation #13025
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #13015
Summary of issue:
When using
vite-plugin-wasm
withvite-plugin-top-level-await
, an external async IIFE is passed alongside the generated component constructor output. Until this top level await function completes, the constructor is undefined. Svelte 5's compiler changes assume, forroot.svelte
, that ifconstructor[1]
is not undefined,constructor[0]
is not undefined. This is true in almost all cases, excepting wherevite-plugin-top-level-await
is used.It seems like Svelte 4's compiler had a fallback constructor when the passed constructor was undefined. Please let me know if the solution is better situated within the Svelte 5 compiler, or perhaps belongs elsewhere! Thanks for your consideration!
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
vite-plugin-top-level-await
in/tests/apps
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits