Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move 'What can I make with SvelteKit' back to FAQ #10547

Merged
merged 4 commits into from
Aug 13, 2023

Conversation

theetrain
Copy link
Contributor

@theetrain theetrain commented Aug 13, 2023

This PR places 'What can I make with SvelteKit' content back to the FAQ, originally added in #10380.

I didn't realize this earlier, but it turns out "What can I make with SvelteKit" was moved to its own page during the new site migration: https://kit.svelte.dev/docs/what-can-i-make-with-sveltekit.

image

If you'd like to keep it that way, then you can disregard this PR.

I have some other drive-by fixes:

  • Any FAQ links meant to go to the new /docs/integrations page now do
  • Any links going to /faq now correctly go to /docs/faq

Another issue I found, but unsure how to fix:

  • The Cloudflare Workers page links to ./faq#how-do-i-use-a-client-side-only-library-that-depends-on-document-or-window, but that heading's slug gets generated as how-do-i-use-x-with-sveltekit-how-do-i-use-a-client-side-only-library-that-depends-on-document-or-window — since it's a level-3 heading, it somehow merges with its respective level-2 heading's slug. I'm not sure if the generated slug is intentionally merged with its upper header, but I adjusted the link to satisfy the build for now.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

- Add back 'what can I make with SvelteKit' to FAQ from sveltejs#10380
- Remove dedicated page for 'what can I make with SvelteKit'
@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2023

⚠️ No Changeset found

Latest commit: 4298e73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theetrain theetrain changed the title Move 'What can I make with SvelteKit' back to FAQ docs: move 'What can I make with SvelteKit' back to FAQ Aug 13, 2023
@ghostdevv
Copy link
Member

The Cloudflare Workers page links to ./faq#how-do-i-use-a-client-side-only-library-that-depends-on-document-or-window, but that heading's slug gets generated as how-do-i-use-x-with-sveltekit-how-do-i-use-a-client-side-only-library-that-depends-on-document-or-window — since it's a level-3 heading, it somehow merges with its respective level-2 heading's slug. I'm not sure if the generated slug is intentionally merged with its upper header, but I adjusted the link to satisfy the build for now.

is that deliberate @PuruVJ ? regardless will merge for now 🙏

@ghostdevv ghostdevv merged commit 8b27b17 into sveltejs:master Aug 13, 2023
11 checks passed
@ghostdevv ghostdevv added the documentation Improvements or additions to documentation label Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants