-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site: sync to current svelte.dev #10187
Conversation
|
documentation/docs/25-build-and-deploy/70-adapter-cloudflare-workers.md
Outdated
Show resolved
Hide resolved
Looks like linting is failing on the CI |
It's not done yet, lots to fix here. Will address when site-kit renderer is robust enough |
@@ -0,0 +1,5 @@ | |||
import { redirect } from '@sveltejs/kit'; | |||
|
|||
export const GET = ({}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a +page.js so that it works with the client side router without a full page reload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
/** @param {URL} url */ | ||
function get_nav_title(url) { | ||
const list = new Map([[/^docs/, 'Docs']]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can just be a list of tuples instead of a map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
svelte.dev uses a map like this, and that has multiple elements. Keeping a map here for consistency sake is not a bad idea IMHO
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
<span class="large"><Icon name="discord" /></span> | ||
</a> | ||
|
||
<a href="https://github.com/sveltejs/svelte" title="GitHub Repo"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PuruVJ wrong link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed: 9c82e14
Syncs this site to svelte.dev, in terms of styling and rendering logic. WIP
closes #10452
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.