Rewrite Makefiles for Examples #2127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts @svaarala? |
|
You can build the Duktape REPL with debugger support for Windows with |
|
Should I close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Makefiles so that they now build incrementally. Previously if you wanted to rebuild an example yo would have to manually delete the binary, and rebuild the entire example, including duktape. This will only rebuild the files that have changed, so duktape will no longer be rebuilt every time, as well, as no longer requiring the user to delete the output binary manually when they want to rebuild the example. It changes the name of the output binary of
Makefile.dukdebugfromduktodukdso that the command line example and the debug command line example don't produce the same binary.