Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NumberFormatException and refactor YahooWeatherProvider #40

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

m-rm
Copy link
Contributor

@m-rm m-rm commented Nov 18, 2015

Hi, basically each commit describes what has been done. I only want to describe "Unify parsing of current weather and forecast" a bit:

Parsing of current and forecast weather was done in similar ways, with a lot of redundant code in both methods. I created a single method to parse it and choose afterwards if current or forecast weather is needed. This has some nice side effects:

  • Units are now also parsed for the current weather
  • Location data is now available in forecast
  • Added latitude and longitude to location since data was available but not parsed yet

@survivingwithandroid
Copy link
Owner

Hi,
thx for your support, Weatherlib needs a code riview and refactoring to improve it.
I will check your pull request and add it into the main branch.

@m-rm
Copy link
Contributor Author

m-rm commented Apr 18, 2016

I added a new commit which implements the recent API changes from Yahoo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants