Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolving circular dependencies #40

Open
wants to merge 2 commits into
base: 3.0
Choose a base branch
from
Open

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Nov 17, 2021

Summary of change

Removes circular dependencies and adds scripts to check for them

Related issues

TODO:

  • Resolve circular dependencies - @nkshah2

@github-actions
Copy link

github-actions bot commented Nov 17, 2021

size-limit report 📦

Path Size
lib/build/index.js 23.84 KB (0%)

@rishabhpoddar
Copy link
Contributor Author

@nkshah2 please finish the rest of this PR. You need to go to this branch, and run npm run check-circular-dependencies. That will list the circular dependencies which you need to resolve.

This is a little tricky since you have separate files for frontToken and idRefreshToken etc.. which all use onUnauthorisedResponse function from fetch.ts. So please think of the best way to remove circular dependencies without unnecessarily passing onUnauthorisedResponse around, and also whilst maintaining separate files for all the token management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant